Bugzilla – Attachment 86668 Details for
Bug 22043
SIP Checkin Response alert flag set to often set to Y incorrectly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22043: SIP Checkin Response alert flag set to often set to Y incorrectly
Bug-22043-SIP-Checkin-Response-alert-flag-set-to-o.patch (text/plain), 2.37 KB, created by
Marcel de Rooy
on 2019-03-15 11:06:08 UTC
(
hide
)
Description:
Bug 22043: SIP Checkin Response alert flag set to often set to Y incorrectly
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-03-15 11:06:08 UTC
Size:
2.37 KB
patch
obsolete
>From 6dee88fa740116e70855b7ae292e7b6e9ccb36eb Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 21 Dec 2018 13:54:18 -0500 >Subject: [PATCH] Bug 22043: SIP Checkin Response alert flag set to often set > to Y incorrectly >Content-Type: text/plain; charset=utf-8 > >If a checkin has any messages at all, even informational like LocalUse, the alert flag ( 4th character of the response ) will be set to Y, even if we do not prove a corresponding alert code in the CV field. We should only set the alert flag if we are going to send a value in the CV field.If a checkin has any messages at all, even informational like LocalUse, the alert flag ( 4th character of the response ) will be set to Y, even if we do not prove a corresponding alert code in the CV field. We should only set the alert flag if we are going to send a value in the CV field. > >Test Plan: >1) Set the checked_in_ok sip account flag to 1 for an account >2) Check in an already checked in item via SIP >3) Note the alert flag is set to Y >4) Apply this patch >5) Restart SIP >6) Check the item in again >7) Note the alert flag is set to N > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Jill Kleven <jill.kleven@pueblolibrary.org> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/SIP/ILS/Transaction/Checkin.pm | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm >index a35009f511..77eb36161f 100644 >--- a/C4/SIP/ILS/Transaction/Checkin.pm >+++ b/C4/SIP/ILS/Transaction/Checkin.pm >@@ -66,8 +66,6 @@ sub do_checkin { > > $debug and warn "do_checkin() calling AddReturn($barcode, $branch)"; > my ($return, $messages, $issue, $borrower) = AddReturn($barcode, $branch, undef, undef, $return_date); >- $self->alert(!$return); >- # ignoring messages: NotIssued, WasLost, WasTransfered > > # biblionumber, biblioitemnumber, itemnumber > # borrowernumber, reservedate, branchcode >@@ -117,7 +115,7 @@ sub do_checkin { > $self->{item}->hold_patron_id( $messages->{ResFound}->{borrowernumber} ); > $self->{item}->destination_loc( $messages->{ResFound}->{branchcode} ); > } >- $self->alert(1) if defined $self->alert_type; # alert_type could be "00", hypothetically >+ $self->alert(defined $self->alert_type); # alert_type could be "00", hypothetically > $self->ok($return); > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22043
:
83468
|
83578
|
85884
|
85897
| 86668 |
86669