From 1eafba717be93c699b076a6d345e5a2a187b3235 Mon Sep 17 00:00:00 2001 From: Hayley Mapley Date: Thu, 14 Mar 2019 04:58:31 +0000 Subject: [PATCH] Bug 13763: Added check for filter syspref in renew.pl In Circulation->Renew, the renew feature does not check the system preference itemBarcodeFilter to see whether the barcode needs to be converted. This patch fixes this, adding a check for the system pref and applying it accordingly to convert the barcode if it is needed. Test plan: 1) In Circulation->Renew, enter a barcode that you know exists in the catalogue but add extra spaces, breaking up the barcode. Note that this fails with a warning that says 'No item matches this barcode' 2) In system Preferences, set the itemBarcodeInputFilter pref to Remove spaces and repeat step1. Note that the result is the same as in step 1 3) Apply the patch 4) Repeat step 1, and note that the filter removes the spaces and the item is renewed (or gives an error that indicates it recognises the barcode) Sponsored-by: Catalyst IT Signed-off-by: Bin Wen --- circ/renew.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/circ/renew.pl b/circ/renew.pl index 5304f405ae..ef1a6ffc1d 100755 --- a/circ/renew.pl +++ b/circ/renew.pl @@ -44,6 +44,7 @@ my ( $template, $librarian, $cookie, $flags ) = get_template_and_user( my $schema = Koha::Database->new()->schema(); my $barcode = $cgi->param('barcode'); +$barcode = barcodedecode($barcode) if( $barcode && C4::Context->preference('itemBarcodeInputFilter')); my $override_limit = $cgi->param('override_limit'); my $override_holds = $cgi->param('override_holds'); -- 2.17.1