From 49730d92c51be347ace8ac320d39c6681870b97d Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 22 Mar 2019 12:57:31 +0000 Subject: [PATCH] Bug 22561: Forgotten password requirements hint doesn't list all rules for new passwords This patch modifies a few templates in the OPAC so that all available information on password requirements is displayed for each case where the patron is setting a password: - If the RequireStrongPassword system preference is set, a message should appear listing strong password requirements and minimum password length. - If RequireStrongPassword is not set, the message should only ask for a minimum password length. To test, apply the patch and enable the PatronSelfRegistration and OpacResetPassword preferences. On the following pages, test with RequireStrongPassword both on and off. The correct messages should appear. - OPAC -> Forgot password. Follow the process to reset your password until you reach the step where you are entering the new password. - OPAC -> Register here. Check the password section of the registration form. - OPAC -> Log in -> Change your password. --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 8 ++++++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 7 ++++++- .../opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt | 8 ++++++-- 3 files changed, 18 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt index 7d238ed..daf56b8 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ -809,9 +809,13 @@
Password
-

Your password must be at least [% Koha.Preference('minPasswordLength') | html %] characters long.

+ [% IF ( Koha.Preference('RequireStrongPassword') ) %] +

Your password must contain at least [% Koha.Preference('minPasswordLength') | html %] characters, including UPPERCASE, lowercase and numbers.

+ [% ELSE %] +

Your password must be at least [% Koha.Preference('minPasswordLength') | html %] characters long.

+ [% END %] [% UNLESS mandatory.defined('password') %] -
If you do not enter a password a system generated password will be created.
+

If you do not enter a password a system generated password will be created.

[% END %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt index 264f1e9..2126742 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt @@ -54,9 +54,14 @@ [% IF ( OpacPasswordChange ) %] [% IF ( Ask_data ) %] +
- [% UNLESS ( ShortPass ) %]
Your password must be at least [% minPasswordLength | html %] characters long.
[% END %] + [% IF ( Koha.Preference('RequireStrongPassword') ) %] +
Your password must contain at least [% Koha.Preference('minPasswordLength') | html %] characters, including UPPERCASE, lowercase and numbers.
+ [% ELSE %] +
Your password must be at least [% Koha.Preference('minPasswordLength') | html %] characters long.
+ [% END %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt index 73eb975..9dc64e9 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt @@ -103,7 +103,11 @@
-
The password must contain at least [% minPasswordLength | html %] characters.
+ [% IF ( Koha.Preference('RequireStrongPassword') ) %] +
Your password must contain at least [% Koha.Preference('minPasswordLength') | html %] characters, including UPPERCASE, lowercase and numbers.
+ [% ELSE %] +
Your password must be at least [% Koha.Preference('minPasswordLength') | html %] characters long.
+ [% END %] @@ -122,7 +126,7 @@
Please click the link in this email to finish the process of resetting your password.
This link is valid for 2 days starting now.

- Return to the main page + Return to the main page [% ELSIF (password_reset_done) %]
-- 2.1.4