Bugzilla – Attachment 87239 Details for
Bug 12441
search.pl has incorrect reference to OPACdefaultSortField and OPACdefaultSortOrder
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12441: Search.pl conditional checks and displays using same syspref
Bug-12441-Searchpl-conditional-checks-and-displays.patch (text/plain), 1.57 KB, created by
Michal Denar
on 2019-03-30 19:09:17 UTC
(
hide
)
Description:
Bug 12441: Search.pl conditional checks and displays using same syspref
Filename:
MIME Type:
Creator:
Michal Denar
Created:
2019-03-30 19:09:17 UTC
Size:
1.57 KB
patch
obsolete
>From 2fb3e634f1c6551a85e3ec332a967b6b1003ec42 Mon Sep 17 00:00:00 2001 >From: Hayley Mapley <hayleymapley@catalyst.net.nz> >Date: Thu, 14 Mar 2019 03:47:59 +0000 >Subject: [PATCH] Bug 12441: Search.pl conditional checks and displays using > same syspref > >Script search.pl checks OPACdefaultSortField and OPACdefaultSortOrder, but >shows defaultSortField and defaultSortOrder when using Advanced Search >in the staff client. > >Test plan: >Apply the patch and then check that the Advanced Search uses >defaultSortOrder and defaultSortField sysprefs instead of the OPAC >sysprefs in the conditional. Check that sort behaviour in Advanced >Search still functions as expected. (It should do - this doesn't change >what displays, just improves consistency). > >Sponsored-by: Catalyst IT > >Signed-off-by: Michal Denar <black23@gmail.com> >--- > catalogue/search.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/catalogue/search.pl b/catalogue/search.pl >index f3d653f737..514c4a9b2c 100755 >--- a/catalogue/search.pl >+++ b/catalogue/search.pl >@@ -282,8 +282,8 @@ if ( $template_type eq 'advsearch' ) { > $template->param(outer_sup_servers_loop => $secondary_servers_loop,); > > # set the default sorting >- if ( C4::Context->preference('OPACdefaultSortField') >- && C4::Context->preference('OPACdefaultSortOrder') ) { >+ if ( C4::Context->preference('defaultSortField') >+ && C4::Context->preference('defaultSortOrder') ) { > my $default_sort_by = > C4::Context->preference('defaultSortField') . '_' > . C4::Context->preference('defaultSortOrder'); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12441
:
86592
|
87239
|
87245