Bugzilla – Attachment 87320 Details for
Bug 21280
Unify MARC editor in biblios and authorities
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21280: Unify field types
Bug-21280-Unify-field-types.patch (text/plain), 3.28 KB, created by
Michal Denar
on 2019-04-02 11:55:07 UTC
(
hide
)
Description:
Bug 21280: Unify field types
Filename:
MIME Type:
Creator:
Michal Denar
Created:
2019-04-02 11:55:07 UTC
Size:
3.28 KB
patch
obsolete
>From 5fc55d1cc0a62857f80bc40b798d41eec57368f4 Mon Sep 17 00:00:00 2001 >From: Ere Maijala <ere.maijala@helsinki.fi> >Date: Fri, 22 Feb 2019 12:22:34 +0200 >Subject: [PATCH] Bug 21280: Unify field types > >Signed-off-by: Michal Denar <black23@gmail.com> > >Signed-off-by: Michal Denar <black23@gmail.com> >--- > Koha/MarcEditor.pm | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/includes/marc_editor.inc | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/MarcEditor.pm b/Koha/MarcEditor.pm >index 85d6c20cec..a71fd3a33e 100644 >--- a/Koha/MarcEditor.pm >+++ b/Koha/MarcEditor.pm >@@ -505,7 +505,7 @@ sub _create_input { > my $is_readonly = $self->{type} eq $Koha::MarcEditor::EDITOR_BIBLIO && !C4::Context->preference("BiblioAddsAuthorities"); > > $subfield_data{marc_value} = { >- type => $self->{type} eq $Koha::MarcEditor::EDITOR_AUTHORITY ? 'text1' : 'text', >+ type => 'text', > id => $subfield_data{id}, > name => $subfield_data{id}, > value => $value, >@@ -526,7 +526,7 @@ sub _create_input { > $plugin->build( $pars ); > if( !$plugin->errstr ) { > $subfield_data{marc_value} = { >- type => $self->{type} eq $Koha::MarcEditor::EDITOR_AUTHORITY ? 'text2' : 'text_complex', >+ type => 'text_complex', > id => $subfield_data{id}, > name => $subfield_data{id}, > value => $value, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/marc_editor.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/marc_editor.inc >index e3abb8dddd..9255dfb1d8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/marc_editor.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/marc_editor.inc >@@ -338,7 +338,7 @@ function Check(){ > [% END %] > > [% SET mv = subfield_loo.marc_value %] >- [% IF ( mv.type == 'text' or mv.type == 'text1' ) %] >+ [% IF ( mv.type == 'text' ) %] > [% IF ( mv.readonly == 1 ) %] > <input type="text" id="[%- mv.id | html -%]" name="[%- mv.name | html -%]" value="[%- mv.value | html -%]" class="input_marceditor readonly" tabindex="1" size="[%- mv.size | html -%]" maxlength="[%- mv.maxlength | html -%]" readonly="readonly" /> > [% ELSE %] >@@ -347,7 +347,7 @@ function Check(){ > [% IF ( mv.authtype ) %] > <span class="subfield_controls"><a href="#" class="buttonDot tag_editor" onclick="openAuth(this.parentNode.parentNode.getElementsByTagName('input')[1].id,'[%- mv.authtype | html -%]','biblio'); return false;" tabindex="1" title="Tag editor">Tag editor</a></span> > [% END %] >- [% ELSIF ( mv.type == 'text_complex' or mv.type == 'text2' ) %] >+ [% ELSIF ( mv.type == 'text_complex' ) %] > <input type="text" id="[%- mv.id | html -%]" name="[%- mv.name | html -%]" value="[%- mv.value | html -%]" class="input_marceditor framework_plugin" tabindex="1" size="[%- mv.size | html -%]" maxlength="[%- mv.maxlength | html -%]" /> > <span class="subfield_controls"> > [% IF mv.noclick %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21280
:
78214
|
85502
|
85503
|
85504
|
85517
|
85518
|
85519
|
85520
|
87311
|
87312
|
87313
|
87314
|
87318
|
87319
|
87320
|
87321
|
89407
|
89408
|
89409
|
89410
|
89411
|
89412
|
89413
|
89414