Bugzilla – Attachment 8781 Details for
Bug 7849
Instant Fine Calculation at Checkin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-Off] Adds instant fine calculation at checkin
Signed-Off-Adds-instant-fine-calculation-at-checki.patch (text/plain), 2.34 KB, created by
Kyle M Hall
on 2012-04-02 17:01:03 UTC
(
hide
)
Description:
[Signed-Off] Adds instant fine calculation at checkin
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2012-04-02 17:01:03 UTC
Size:
2.34 KB
patch
obsolete
>From 6805213c7a398d91a1f0df7fd7639b948a05318f Mon Sep 17 00:00:00 2001 >From: Elliott Davis <tdavis@uttyler.edu> >Date: Thu, 29 Mar 2012 20:05:10 +0000 >Subject: [PATCH] [Signed-Off] Adds instant fine calculation at checkin > >http://bugs.koha-community.org/show_bug.cgi?id=7849 >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Circulation.pm | 20 ++++++++++++++++++-- > 1 files changed, 18 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 9c43f36..0adb8e3 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -36,6 +36,7 @@ use C4::Message; > use C4::Debug; > use C4::Branch; # GetBranches > use C4::Log; # logaction >+use C4::Overdues qw(CalcFine UpdateFine); > > use Data::Dumper; > use Koha::DateUtils; >@@ -1595,17 +1596,32 @@ sub AddReturn { > > # case of a return of document (deal with issues and holdingbranch) > if ($doreturn) { >+ my $today = DateTime->now( time_zone => C4::Context->tz() ); >+ my $datedue = $issue->{date_due}; > $borrower or warn "AddReturn without current borrower"; >- my $circControlBranch; >+ my $circControlBranch; > if ($dropbox) { > # define circControlBranch only if dropbox mode is set > # don't allow dropbox mode to create an invalid entry in issues (issuedate > today) > # FIXME: check issuedate > returndate, factoring in holidays > #$circControlBranch = _GetCircControlBranch($item,$borrower) unless ( $item->{'issuedate'} eq C4::Dates->today('iso') );; > $circControlBranch = _GetCircControlBranch($item,$borrower); >+ $today->add(days => -1 ); >+ $issue->{'overdue'} = DateTime->compare($issue->{'date_due'}, $today ) == -1 ? 1 : 0; > } >- > if ($borrowernumber) { >+ if($issue->{'overdue'}){ >+ my ( $amount, $type, $daycounttotal ) = C4::Overdues::CalcFine( $item, $borrower->{categorycode},$branch, $datedue, $today ); >+ my $type ||= q{}; >+ print STDERR "\n\nAMOUNT: $amount"; >+ if ( $amount > 0 ) { >+ C4::Overdues::UpdateFine( >+ $issue->{itemnumber}, >+ $issue->{borrowernumber}, >+ $amount, $type, output_pref($datedue) >+ ); >+ } >+ } > MarkIssueReturned($borrowernumber, $item->{'itemnumber'}, $circControlBranch, '', $borrower->{'privacy'}); > $messages->{'WasReturned'} = 1; # FIXME is the "= 1" right? This could be the borrower hash. > } >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7849
:
8703
|
8781
|
8879
|
8907
|
9012
|
9231
|
9284