Bugzilla – Attachment 87965 Details for
Bug 22090
Cash register report missing data in CSV export
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22090: Add missing information to cash register CSV file
Bug-22090-Add-missing-information-to-cash-register.patch (text/plain), 3.98 KB, created by
Chris Cormack
on 2019-04-14 22:28:59 UTC
(
hide
)
Description:
Bug 22090: Add missing information to cash register CSV file
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2019-04-14 22:28:59 UTC
Size:
3.98 KB
patch
obsolete
>From 93b5b141d26dc7c527f3598fc291230d2371fef3 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 7 Apr 2019 18:23:32 +0000 >Subject: [PATCH] Bug 22090: Add missing information to cash register CSV file > >Some information was missing from the CSV export file >of the Cash register report: manager surname, patron surname >and payment notes. > >Also pretties up the column headers a bit and makes the >sequence between GUI and CSV export match. > >To test: >- Make sure you have some fines and fees and payments in > your system >- Make a search with the Cash register report >- Export results as CSV >- Proof read hader line and make sure contents match headings >- Verify first name and surname are shown for manager and patron >- Verify notes show up > >Signed-off-by: Michal Denar <black23@gmail.com> >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > .../prog/en/includes/csv_headers/reports/cash_register_stats.tt | 2 +- > .../intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt | 2 +- > reports/cash_register_stats.pl | 6 +++--- > 3 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/reports/cash_register_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/reports/cash_register_stats.tt >index ffc92c8c96..a475c76d6c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/reports/cash_register_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/reports/cash_register_stats.tt >@@ -1 +1 @@ >-[%- BLOCK -%]mfirstname[% sep | html %]card number[% sep | html %]firstname[% sep | html %]branchname[% sep | html %]date[% sep | html %]accounttype[% sep | html %]amount[% sep | html %]title[% sep | html %]barcode[% sep | html %]itype[%- END -%] >+[%- BLOCK -%]Manager name[% sep | html %]Patron cardnumber[% sep | html %]Patron name[% sep | html %]Transaction library[% sep | html %]Transaction date[% sep | html %]Transaction type[% sep |html %]Notes[% sep | html %]Amount[% sep | html %]Title[% sep | html %]Barcode[% sep | html %]Item type[%- END -%] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt >index 6a3e10b6a6..1aca2fb209 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt >@@ -131,7 +131,7 @@ > </select> > </li> > <li> >- <label>Transaction branch</label> >+ <label>Transaction library</label> > <select name="branch" id="branch"> > <option value="ALL">All</option> > [% FOREACH branchloo IN branchloop %] >diff --git a/reports/cash_register_stats.pl b/reports/cash_register_stats.pl >index 0a1ff54fcc..b030f6684e 100755 >--- a/reports/cash_register_stats.pl >+++ b/reports/cash_register_stats.pl >@@ -143,17 +143,17 @@ if ($do_it) { > my $format = 'csv'; > my $reportname = $input->param('basename'); > my $reportfilename = $reportname ? "$reportname.$format" : "reportresults.$format" ; >- #my $reportfilename = "$reportname.html" ; > my $delimiter = C4::Context->preference('delimiter') || ','; > my @rows; > foreach my $row (@loopresult) { > my @rowValues; >- push @rowValues, $row->{mfirstname}, >+ push @rowValues, $row->{mfirstname}. ' ' . $row->{msurname}, > $row->{cardnumber}, >- $row->{bfirstname}, >+ $row->{bfirstname} . ' ' . $row->{bsurname}, > $row->{branchname}, > $row->{date}, > $row->{accounttype}, >+ $row->{note}, > $row->{amount}, > $row->{title}, > $row->{barcode}, >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22090
:
87487
|
87548
| 87965