Bugzilla – Attachment 88037 Details for
Bug 8701
Help for OpacHiddenItems pref should not point to text in install directory
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8701: Remove links to OpacHiddenItems.txt in favor of wiki page
Bug-8701-Remove-links-to-OpacHiddenItemstxt-in-fav.patch (text/plain), 3.90 KB, created by
Hayley Pelham
on 2019-04-15 22:19:06 UTC
(
hide
)
Description:
Bug 8701: Remove links to OpacHiddenItems.txt in favor of wiki page
Filename:
MIME Type:
Creator:
Hayley Pelham
Created:
2019-04-15 22:19:06 UTC
Size:
3.90 KB
patch
obsolete
>From 767777c002b762845c9103f0447bce03a3c5c948 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sat, 16 Mar 2019 13:19:11 +0100 >Subject: [PATCH] Bug 8701: Remove links to OpacHiddenItems.txt in favor of > wiki page > >Removes the OpacHiddenItems.txt file from Koha as this is not >accessible for most people and replaces it with links to the wiki >page like it's already done from the system preference editor. > >For reporting and the initial patch >Thanks-to: Jane Sandberg <sandbej@linnbenton.edu> > >To test: >- Changes are invisible from the GUI >- Apply patch and run database update >- SELECT * FROM systempreferences WHERE variable = "OpacHiddenItems"; >- Verify the description has the wiki link >- Verify that docs/opac/OpacHiddenItems.txt has been removed > >Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> >--- > docs/opac/OpacHiddenItems.txt | 12 ------------ > .../data/mysql/atomicupdate/bug_8701_opachiddenitems.perl | 6 ++++++ > installer/data/mysql/sysprefs.sql | 2 +- > 3 files changed, 7 insertions(+), 13 deletions(-) > delete mode 100644 docs/opac/OpacHiddenItems.txt > create mode 100644 installer/data/mysql/atomicupdate/bug_8701_opachiddenitems.perl > >diff --git a/docs/opac/OpacHiddenItems.txt b/docs/opac/OpacHiddenItems.txt >deleted file mode 100644 >index d46f94b114..0000000000 >--- a/docs/opac/OpacHiddenItems.txt >+++ /dev/null >@@ -1,12 +0,0 @@ >-The OpacHiddenItems syspref allow the user to define custom rules >-for hiding specific items at opac. >- >-YAML syntax is used for defining such rules. >- >-Items can be hidden according to values from the items table: >- >-field: [value1, value2, ...] >- >-Example : >-withdrawn: [0, 1] >-homebranch: [homebranch1, homebranch2] >diff --git a/installer/data/mysql/atomicupdate/bug_8701_opachiddenitems.perl b/installer/data/mysql/atomicupdate/bug_8701_opachiddenitems.perl >new file mode 100644 >index 0000000000..f6a60ac4c7 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_8701_opachiddenitems.perl >@@ -0,0 +1,6 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if( CheckVersion( $DBversion ) ) { >+ $dbh->do( "UPDATE systempreferences SET explanation = 'This syspref allows to define custom rules for hiding specific items at the OPAC. See http://wiki.koha-community.org/wiki/OpacHiddenItems for more information.' WHERE variable = 'OpacHiddenItems'"); >+ SetVersion( $DBversion ); >+ print "Upgrade to $DBversion done (Bug 8701 - Update OpacHiddenItems system preference description)\n"; >+} >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 0a983e35ef..e0b7959614 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -361,7 +361,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('OPACFinesTab','1','','If OFF the patron fines tab in the OPAC is disabled.','YesNo'), > ('OPACFRBRizeEditions','0','','If ON, the OPAC will query one or more ISBN web services for associated ISBNs and display an Editions tab on the details pages','YesNo'), > ('opacheader','','70|10','Add HTML to be included as a custom header in the OPAC','Textarea'), >-('OpacHiddenItems','','','This syspref allows to define custom rules for hiding specific items at opac. See docs/opac/OpacHiddenItems.txt for more informations.','Textarea'), >+('OpacHiddenItems','','','This syspref allows to define custom rules for hiding specific items at the OPAC. See http://wiki.koha-community.org/wiki/OpacHiddenItems for more information.','Textarea'), > ('OpacHiddenItemsExceptions','',NULL,'List of borrower categories, separated by |, that can see items otherwise hidden by OpacHiddenItems','Textarea'), > ('OpacHighlightedWords','1','','If Set, then queried words are higlighted in OPAC','YesNo'), > ('OPACHoldingsDefaultSortField','first_column','first_column|homebranch|holdingbranch','Default sort field for the holdings table at the OPAC','choice'), >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8701
:
12733
|
86704
|
86705
|
88037
|
88160