Attachment 88073 Details for Bug 22547 – Bug 22547: (QA follow-up) Warn in debug mode

[patch] Bug 22547: (QA follow-up) Warn in debug mode

Bug-22547-QA-follow-up-Warn-in-debug-mode.patch (text/plain), 1.43 KB, created by Martin Renvoize on 2019-04-16 14:03:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize

Created: 2019-04-16 14:03:16 UTC

Size: 1.43 KB

patch

obsolete

>From 2adfe4928a1711c0f27266b647762c0f712b92d9 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 9 Apr 2019 13:47:35 -0300
>Subject: [PATCH] Bug 22547: (QA follow-up) Warn in debug mode
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> C4/Overdues.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Overdues.pm b/C4/Overdues.pm
>index b44aa583b2..a6ff257797 100644
>--- a/C4/Overdues.pm
>+++ b/C4/Overdues.pm
>@@ -551,7 +551,7 @@ sub UpdateFine {
>     while (my $rec = $sth->fetchrow_hashref) {
>         if ( $rec->{issue_id} == $issue_id && $rec->{accounttype} eq 'FU' ) {
>             if ($data) {
>-                warn "Not a unique accountlines record for issue_id $issue_id";
>+                $debug and warn "Not a unique accountlines record for issue_id $issue_id";
>                 #FIXME Should we still count this one in total_amount ??
>             }
>             else {
>@@ -566,7 +566,7 @@ sub UpdateFine {
>         if ($total_amount_other + $amount > $maxfine) {
>             my $new_amount = $maxfine - $total_amount_other;
>             return if $new_amount <= 0.00;
>-            warn "Reducing fine for item $itemnum borrower $borrowernumber from $amount to $new_amount - MaxFine reached";
>+            $debug and warn "Reducing fine for item $itemnum borrower $borrowernumber from $amount to $new_amount - MaxFine reached";
>             $amount = $new_amount;
>         }
>     }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22547: 86782 | 86790 | 87051 | 87643 | 87644 | 88072 | 88073