Bugzilla – Attachment 88214 Details for
Bug 22464
Copyright notice does not pass forward request properties
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22464: Pass forward parameters
Bug-22464-Pass-forward-parameters.patch (text/plain), 2.82 KB, created by
Liz Rea
on 2019-04-17 15:57:53 UTC
(
hide
)
Description:
Bug 22464: Pass forward parameters
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2019-04-17 15:57:53 UTC
Size:
2.82 KB
patch
obsolete
>From e955c782954931d98766e2b9111d5077961e19c9 Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Wed, 6 Mar 2019 14:07:50 +0000 >Subject: [PATCH] Bug 22464: Pass forward parameters > >This patch ensures that parameters that are present are passed forward >when accepting the copyright notice. > >Test plan: > >- Clone the latest version of the FreeForm backend from: > https://github.com/PTFS-Europe/koha-ill-freeform >- Ensure the ILLModuleCopyrightClearance syspref is populated >- Create an OpenURL in order to pre-populate the FreeForm form, a suitable URL would be: > ><your_koha_instance>/cgi-bin/koha/opac-illrequests.pl?openurl=true&backend=FreeForm&method=create&opac=1&atitle=Theater%20careers.%20%5Belectronic%20resource%5D%20%3A%20a%20realistic%20guide.&aulast=Donahue%2C%20Tim&date=2012&genre=article&isbn=978123123123&issn=1234-5678&issue=34&pages=12-34&sid=EBSCO%3AAthlone%20Institute%20of%20Technology%3Aait.101326&title=article%20title%20here&volume=12 > >- Log in >- Accept the copyright notice >=> TEST: Observe that the FreeForm form is pre-filled with the metadata >supplied in the OpenURL > >Signed-off-by: Liz Rea <wizzyrea@gmail.com> >--- > Koha/Illrequest.pm | 1 + > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) > >diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm >index 57e47260dd..1ca2991628 100644 >--- a/Koha/Illrequest.pm >+++ b/Koha/Illrequest.pm >@@ -785,6 +785,7 @@ sub backend_create { > method => 'create', > stage => 'copyrightclearance', > value => { >+ other => $params, > backend => $self->_backend->name > } > }; >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >index 64a057dd0e..218a6e2aa2 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >@@ -62,7 +62,8 @@ > <p> > [% Koha.Preference('ILLModuleCopyrightClearance') | $raw %] > </p> >- <a href="?method=create&stage=copyrightclearance&backend=[% whole.value.backend | uri %]" >+ [% USE link_url = url('/cgi-bin/koha/opac-illrequests.pl', whole.value.other) %] >+ <a href="[% link_url _ '&stage=copyrightclearance' | $raw %]" > class="btn btn-sm btn-default"><i class="fa fa-check"></i> Yes</a> > <a href="/cgi-bin/koha/opac-illrequests.pl" > class="btn btn-sm btn-default"><i class="fa fa-times"></i> No</a> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22464
:
86184
|
88214
|
88289