From f95cbc183b26deff7002686b8d236206bb9c3c1c Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Mon, 22 Apr 2019 10:08:41 -0300 Subject: [PATCH] Bug 22701: Make items prefetchable from Koha::Biblio This patch makes Koha::Biblio->items use _new_from_dbic instead of calling Koha::Items->search. This allows calling it with prefetch enabled for the items relationship. No noticeable behaviour change takes place besides this. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Martin Renvoize --- Koha/Biblio.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm index 56f91859d5..5389d6b688 100644 --- a/Koha/Biblio.pm +++ b/Koha/Biblio.pm @@ -362,9 +362,12 @@ or list of Koha::Item objects in list context. sub items { my ($self) = @_; - $self->{_items} ||= Koha::Items->search( { biblionumber => $self->biblionumber() } ); + my $items_rs = $self->_result->items; - return wantarray ? $self->{_items}->as_list : $self->{_items}; + return + wantarray + ? Koha::Items->_new_from_dbic($items_rs)->as_list + : Koha::Items->_new_from_dbic($items_rs); } =head3 itemtype -- 2.20.1