Bugzilla – Attachment 88690 Details for
Bug 19241
Items with status of hold show as available in cart
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19241: Waiting items show as available in the cart
Bug-19241-Waiting-items-show-as-available-in-the-c.patch (text/plain), 1.45 KB, created by
Martin Renvoize
on 2019-04-25 07:03:29 UTC
(
hide
)
Description:
Bug 19241: Waiting items show as available in the cart
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2019-04-25 07:03:29 UTC
Size:
1.45 KB
patch
obsolete
>From 84e5c9389bb28934a22f020e5a29e798a863b8b6 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 16 Apr 2019 17:21:01 +0000 >Subject: [PATCH] Bug 19241: Waiting items show as available in the cart > >The cart uses the same item-status.inc that the details page uses, however, we don't >set the waiting or reserved flags. This patch adds those flags to the script > >To test: >1 - Find an item on the opac >2 - Place a hold on the item >3 - Check in the item to confirm the hold >4 - Note the details page on OPAC shows 'On hold' >5 - Add the item to a basket >6 - Note the basket shows 'Available' >7 - Apply patch >8 - Check the cart, should show as 'On hold' > >Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > opac/opac-basket.pl | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/opac/opac-basket.pl b/opac/opac-basket.pl >index d66fd0127c..c2d57f2f5e 100755 >--- a/opac/opac-basket.pl >+++ b/opac/opac-basket.pl >@@ -101,6 +101,9 @@ foreach my $biblionumber ( @bibs ) { > my @items; > foreach my $item (@all_items) { > if ( none { $item->{itemnumber} ne $_ } @hidden_items ) { >+ my $reserve_status = C4::Reserves::GetReserveStatus($item->{itemnumber}); >+ if( $reserve_status eq "Waiting"){ $item->{'waiting'} = 1; } >+ if( $reserve_status eq "Reserved"){ $item->{'onhold'} = 1; } > push @items, $item; > } > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19241
:
66784
|
88093
|
88127
| 88690