From 5b5fa70d5183fd31c8e5ab7c77f2fb0527945b0d Mon Sep 17 00:00:00 2001 From: Hayley Mapley Date: Fri, 26 Apr 2019 14:52:53 +1200 Subject: [PATCH] Bug 18308: Removed warns and moved password length warning to template Sponsored-by: Catalyst IT --- installer/onboarding.pl | 1 - koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- members/memberentry.pl | 3 +-- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/installer/onboarding.pl b/installer/onboarding.pl index 3d2e2a4597..eebfe80759 100755 --- a/installer/onboarding.pl +++ b/installer/onboarding.pl @@ -146,7 +146,6 @@ if ( $step == 3 ) { if ( $op eq 'set_validate_min_password_length' ) { my $minPasswordLength = $input->param('pref_minPasswordLength'); - warn $minPasswordLength; C4::Context->set_preference( 'minPasswordLength', $minPasswordLength ); unless ($@) { push @messages, { code => 'success_on_update_minPasswordLength_syspref' }; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt index 2ec1d47cdc..49b05ea433 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ -133,7 +133,7 @@ [% IF passwordwarning %]
-

Warning: [% passwordwarning | html %]

+

Warning: Your minPasswordLength system preference is less than 8 characters. This means library patrons can potentially set passwords which are vulnerable to cracking. Please set your minPasswordLength syspref to 8 or more characters.

[% END %] diff --git a/members/memberentry.pl b/members/memberentry.pl index 2040e57de3..2b3418c49b 100755 --- a/members/memberentry.pl +++ b/members/memberentry.pl @@ -173,9 +173,8 @@ $category_type="A" unless $category_type; # FIXME we should display a error mess #Check passwords my $minPasswordLength = C4::Context->preference('minPasswordLength'); -warn $minPasswordLength; if ($minPasswordLength < 8) { - warn my $warning = "Your minPasswordLength system preference is less than 8 characters this means library patrons can potentially set passwords which are vulnerable to cracking. Please set your minPasswordLength syspref to 8 or more characters"; + my $warning = 1; $template->param("passwordwarning"=>$warning); } -- 2.11.0