From 98e6d2401ee36425362e791e0e1871604b7196ae Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 26 Apr 2019 09:05:01 +0000 Subject: [PATCH] Bug 8000: (QA follow-up) Two lastminute fixes Content-Type: text/plain; charset=utf-8 [1] Number of tests Letters.t [2] Resolving uninitialized warn on Letters, L1327 Signed-off-by: Marcel de Rooy --- C4/Letters.pm | 2 +- t/db_dependent/Letters.t | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Letters.pm b/C4/Letters.pm index 2ce5db359c..b8175f5521 100644 --- a/C4/Letters.pm +++ b/C4/Letters.pm @@ -1324,7 +1324,7 @@ sub _send_message_by_email { $sendmail_params{'Auth'} = {user => $username, pass => $password, method => $method} if $username; - _update_message_to_address($message->{'message_id'},$sendmail_params{To}) if $message->{to_address} ne $sendmail_params{To}; #if initial message address was empty, coming here means that a to address was found and queue should be updated; same if to address was overriden by create_message_headers + _update_message_to_address($message->{'message_id'},$sendmail_params{To}) if !$message->{to_address} || $message->{to_address} ne $sendmail_params{To}; #if initial message address was empty, coming here means that a to address was found and queue should be updated; same if to address was overriden by create_message_headers if ( Mail::Sendmail::sendmail( %sendmail_params ) ) { _set_message_status( { message_id => $message->{'message_id'}, diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t index 8bd76fca4a..41f2a05fb8 100644 --- a/t/db_dependent/Letters.t +++ b/t/db_dependent/Letters.t @@ -18,7 +18,7 @@ # along with Koha; if not, see . use Modern::Perl; -use Test::More tests => 67; +use Test::More tests => 69; use Test::MockModule; use Test::Warn; -- 2.11.0