From a9e8a3cf51f2e14775d6f176f651bf2e6742d695 Mon Sep 17 00:00:00 2001 From: Agustin Moyano Date: Thu, 4 Apr 2019 01:10:16 -0300 Subject: [PATCH] Bug 22284: New messages in reserve/request.tt This patch adds new messages to 'Hold' column in 'Place a hold on a specific item' table Those messages are 1) Cannot place hold from patrons's library: this message appears when patron's homebranch is not in item's hold group 2) Pickup library is not in hold group: self explanatory To test: 1) In library groups add a root group and check it as hold group. 2) Add a library to the group 3) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 4) Search a patron from a different library than step 2, select one and click 'search to hold' 5) Search by location for items in the library of step 2 6) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column 7) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 4 to 5 9) Find a biblio with items in 2 different libraries SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Pickup library is not in hold group" in 'Hold' column for the item that has no hold group 10) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi --- koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index c18ea1068b..6c09f369df 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -342,10 +342,14 @@ Not holdable [% ELSIF itemloo.not_holdable == 'cannotReserveFromOtherBranches' %] Patron is from different library + [% ELSIF itemloo.not_holdable == 'branchNotInHoldGroup' %] + Cannot place hold from patrons's library [% ELSIF itemloo.not_holdable == 'itemAlreadyOnHold' %] Patron already has hold for this item [% ELSIF itemloo.not_holdable == 'cannotBeTransferred' %] Cannot be transferred to pickup library + [% ELSIF itemloo.not_holdable == 'pickupNotInHoldGroup' %] + Pickup library is not in hold group [% ELSE %] [% itemloo.not_holdable | html %] [% END %] -- 2.11.0