From 27acc97f7fdf9f40c214037ad1fd493531bf1a18 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Sun, 28 Apr 2019 22:53:55 -0400 Subject: [PATCH] Bug 13420: Sort "Serial enumeration" by published date So far the sorting on volume information is incorrect. It sorts by the string displayed in the cell, which may not have any logics. A better solution would be to use Kyle's suggestion, see comments 7, 8, but it will need much more work. This patch suggests to use the publication date to sort this column. Note: In the code there is a switch depending on the existence of items.publisheddate, but I do not think it is valid, this valid should always exist if the item is received (did I miss something?) Test plan: You need to have different existing subscription, using different numbering. On the detail page of the bibliographic record you should be able to sort the serials (tab "Holdings") by "Serial enumeration". The sort will now use the publication dates. --- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index 6520134dc2..a7089fd1d2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -198,7 +198,7 @@ Home library [% IF ( itemdata_ccode ) %]Collection[% END %] Call number - [% IF ( volinfo ) %]Serial enumeration / chronology[% END %] + [% IF volinfo %]Serial enumeration / chronology[% END %] Status Last seen Date accessioned @@ -241,6 +241,7 @@ [% IF ( item.itemcallnumber ) %] [% item.itemcallnumber | html %][% END %] [% IF ( volinfo ) %] + [% IF ( itemdata_enumchron ) %] [% IF item.enumchron && item.serialseq %] [% item.enumchron | html %] @@ -257,6 +258,7 @@ ([% item.publisheddate | $KohaDates %]) [% END %] [% END %] + [% END %] -- 2.11.0