From dc030827dc5230a9af34da6453ff5c8290593851 Mon Sep 17 00:00:00 2001 From: Andrew Isherwood Date: Thu, 7 Feb 2019 14:43:55 +0000 Subject: [PATCH] Bug 7088: (follow-up) Default hold checkbox display As per item 4 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Now, the checkbox for renewing on hold items behaves the same way as the checkbox for renewing items that have reached their renew limit. It is necessary to check the re-labelled "Override renewal restrictions" checkbox before it is possible to select on-hold items for renewal. Signed-off-by: Liz Rea --- koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc | 2 +- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc index 7b4b622762..00c41077e9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc @@ -41,7 +41,7 @@
[% IF ( CAN_user_circulate_override_renewals ) %] [% IF CAN_user_circulate_override_renewals && Koha.Preference( 'AllowRenewalLimitOverride' ) %] - + [% END %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js index 7750ceb6a4..4035183a21 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js +++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js @@ -408,11 +408,12 @@ $(document).ready(function() { if ( oObj.can_renew ) { // Do nothing } else if ( oObj.can_renew_error == "on_reserve" ) { - msg += "" + msg += "" + "" + ON_HOLD + "" + ""; - span_style = AllowRenewalLimitOverride ? "" : "display: none"; + span_style = "display: none"; + span_class = "renewals-allowed"; } else if ( oObj.can_renew_error == "too_many" ) { msg += "" + NOT_RENEWABLE -- 2.11.0