Bugzilla – Attachment 89039 Details for
Bug 22806
CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22806 : CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions
Bug-22806--CanBookBeReserved-and-CanItemBeReserved.patch (text/plain), 1.97 KB, created by
Arthur Suzuki
on 2019-04-29 17:04:21 UTC
(
hide
)
Description:
Bug 22806 : CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions
Filename:
MIME Type:
Creator:
Arthur Suzuki
Created:
2019-04-29 17:04:21 UTC
Size:
1.97 KB
patch
obsolete
>From 4ca5b8207c16911038f66dda2391bac34ef012d3 Mon Sep 17 00:00:00 2001 >From: Arthur Suzuki <arthur.suzuki@biblibre.com> >Date: Mon, 29 Apr 2019 18:55:16 +0200 >Subject: [PATCH] Bug 22806 : CanBookBeReserved and CanItemBeReserved must > check AllowHoldsOnPatronsPossessions > >Test plan : >1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" >2 - Checkout an item to a borrower >3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. >4 - Cancel the hold and apply patch >5 - Repeat 3 -> Should not place hold and reply "itemAlreadyOnLoan" > >Veuillez saisir le message de validation pour vos modifications. Les lignes >--- > C4/Reserves.pm | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index e8f00d625b..bcf0378057 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -283,6 +283,12 @@ sub CanBookBeReserved{ > } > } > >+ # Check that patron have not checked out this biblio (if AllowHoldsOnPatronsPossessions set) >+ if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions') >+ && C4::Circulation::CheckIfIssuedToPatron( $patron->borrowernumber, $biblionumber ) ) { >+ return { status =>'itemAlreadyOnLoan' }; >+ } >+ > # Check if borrower has reached the maximum number of holds allowed > my $maxreserves = C4::Context->preference('maxreserves'); > if ($maxreserves && $holds->count >= $maxreserves) { >@@ -368,6 +374,12 @@ sub CanItemBeReserved { > } > } > >+ # Check that patron have not checked out this biblio (if AllowHoldsOnPatronsPossessions set) >+ if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions') >+ && C4::Circulation::CheckIfIssuedToPatron( $patron->borrowernumber, $biblio->biblionumber ) ) { >+ return { status =>'itemAlreadyOnLoan' }; >+ } >+ > # Check if borrower has reached the maximum number of holds allowed > my $maxreserves = C4::Context->preference('maxreserves'); > if ($maxreserves && $holds->count >= $maxreserves) { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22806
:
89039
|
89724
|
91784
|
94388
|
94389
|
97947
|
99881
|
99882
|
99883
|
99884
|
99885
|
100091
|
100092
|
100093
|
100173
|
100174
|
100175
|
106564
|
106778
|
106779
|
106780
|
107760
|
107806
|
110100
|
110101
|
110102
|
110973
|
110974
|
110975
|
110976
|
111771
|
111772
|
111773
|
111774
|
112824