Bugzilla – Attachment 89266 Details for
Bug 22836
Tests catching XSS vulnerabilities in pagination are not correct
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22836: (follow-up) Bug 22478: (QA follow-up) Make test consistent with variable name
Bug-22836-follow-up-Bug-22478-QA-follow-up-Make-te.patch (text/plain), 1.36 KB, created by
Jonathan Druart
on 2019-05-03 01:06:26 UTC
(
hide
)
Description:
Bug 22836: (follow-up) Bug 22478: (QA follow-up) Make test consistent with variable name
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-05-03 01:06:26 UTC
Size:
1.36 KB
patch
obsolete
>From f5eebd9b345620b3bd600c797363e4affb6de357 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 2 May 2019 21:04:54 -0400 >Subject: [PATCH] Bug 22836: (follow-up) Bug 22478: (QA follow-up) Make test > consistent with variable name > >One occurrence was missing. >--- > t/db_dependent/selenium/regressions.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/selenium/regressions.t b/t/db_dependent/selenium/regressions.t >index ac24963bde..b48a251c18 100644 >--- a/t/db_dependent/selenium/regressions.t >+++ b/t/db_dependent/selenium/regressions.t >@@ -228,7 +228,7 @@ subtest 'XSS vulnerabilities in pagination' => sub { > is( $alert_text, undef, 'No alert box displayed, even if evil intent' ); > > my $second_page = $driver->find_element('//div[@class="pages"]/span[@class="currentPage"]/following-sibling::a'); >- like( $second_page->get_attribute('href'), qr{category=1%22%3E%3Cscript%3Ealert%28%27booh%21%27%29%3C%2Fscript%3E}, 'The second patch should displayed the variables and attributes correctly URI escaped' ); >+ like( $second_page->get_attribute('href'), qr{category=2%22%3E%3Cscript%3Ealert%28%27booh%21%27%29%3C%2Fscript%3E}, 'The second patch should displayed the variables and attributes correctly URI escaped' ); > > push @cleanup, $patron, $patron->category, $patron->library; > }; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22836
:
89264
|
89265
|
89266
|
89677
|
89678
|
89679
|
89710
|
89711
|
89712