From fec9f4dac32fee14d80e99fb307e50f1abd2ddb6 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 1 May 2019 21:05:30 -0400 Subject: [PATCH] Bug 22781: Correctly filter the emails Ho, another bug! The email was not correctly filtered. Test plan: Use the evil string for an email, do a search. => Notice that without this patch the results never show up --- .../prog/en/modules/members/tables/members_results.tt | 2 +- t/db_dependent/selenium/patrons_search.t | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt index 21853df433..2c047fd8f5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt @@ -17,7 +17,7 @@ "dt_cardnumber": "[% data.cardnumber | html | $To %]", "dt_name": - "[% INCLUDE 'patron-title.inc' borrowernumber = data.borrowernumber category_type = data.category_type firstname = data.firstname surname = data.surname othernames = data.othernames invert_name = 1 | $To %]
[% INCLUDE escape_address data = data %][% IF data.email %]
Email: [% data.email | html %][% END %]", + "[% INCLUDE 'patron-title.inc' borrowernumber = data.borrowernumber category_type = data.category_type firstname = data.firstname surname = data.surname othernames = data.othernames invert_name = 1 | $To %]
[% INCLUDE escape_address data = data %][% IF data.email %]
Email: [% data.email | html | $To %][% END %]", "dt_dateofbirth": "[% data.dateofbirth | $KohaDates %]", "dt_category": diff --git a/t/db_dependent/selenium/patrons_search.t b/t/db_dependent/selenium/patrons_search.t index 5a27e2f116..fa5344d721 100644 --- a/t/db_dependent/selenium/patrons_search.t +++ b/t/db_dependent/selenium/patrons_search.t @@ -40,7 +40,7 @@ my $builder = t::lib::TestBuilder->new; our @cleanup; subtest 'Search patrons' => sub { - plan tests => 5; + plan tests => 6; my @patrons; my $borrowernotes = q|just 'a" note \123 ❤|; @@ -48,6 +48,7 @@ subtest 'Search patrons' => sub { my $branchname = q|just 'another" library \123 ❤|; my $firstname = q|fir's"tname \123 ❤|; my $address = q|add'res"s \123 ❤|; + my $email = q|abad_email@example\123 ❤.com|; my $patron_category = $builder->build_object( { class => 'Koha::Patron::Categories', category_type => 'A' } ); my $library = $builder->build_object( @@ -65,6 +66,7 @@ subtest 'Search patrons' => sub { branchcode => $library->branchcode, borrowernotes => $borrowernotes, address => $address, + email => $email, } } ); @@ -83,6 +85,9 @@ subtest 'Search patrons' => sub { like ($td[2]->get_text, qr[\Q$address\E], 'Column "Name" should be the 3rd and contain the address correctly filtered' ); + like ($td[2]->get_text, qr[\Q$email\E], + 'Column "Name" should be the 3rd and contain the email address correctly filtered' + ); is( $td[5]->get_text, $branchname, 'Column "Library" should be the 6th and contain the html tags - they have been html filtered' ); -- 2.11.0