From 561b8b6af6815f8b8f89b86d2f5ab119b95ec4f9 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 2 May 2019 14:00:52 -0300 Subject: [PATCH] Bug 21073: Regression tests for GetPlugins Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano --- t/db_dependent/Plugins.t | 101 ++++++++++++++++++++++++++++++----------------- 1 file changed, 65 insertions(+), 36 deletions(-) diff --git a/t/db_dependent/Plugins.t b/t/db_dependent/Plugins.t index da9001be96..34764214c6 100755 --- a/t/db_dependent/Plugins.t +++ b/t/db_dependent/Plugins.t @@ -1,5 +1,19 @@ #!/usr/bin/perl +# This file is part of Koha. +# +# Koha is free software; you can redistribute it and/or modify it under the +# terms of the GNU General Public License as published by the Free Software +# Foundation; either version 3 of the License, or (at your option) any later +# version. +# +# Koha is distributed in the hope that it will be useful, but WITHOUT ANY +# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR +# A PARTICULAR PURPOSE. See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License along +# with Koha; if not, see . + use Modern::Perl; use Archive::Extract; @@ -9,7 +23,7 @@ use File::Temp qw( tempdir tempfile ); use FindBin qw($Bin); use Module::Load::Conditional qw(can_load); use Test::MockModule; -use Test::More tests => 42; +use Test::More tests => 41; use C4::Context; use Koha::Database; @@ -18,7 +32,9 @@ use Koha::Plugins::Methods; use t::lib::Mocks; BEGIN { - push( @INC, dirname(__FILE__) . '/../lib' ); + # Mock pluginsdir before loading Plugins module + my $path = dirname(__FILE__) . '/../lib'; + t::lib::Mocks::mock_config( 'pluginsdir', $path ); use_ok('Koha::Plugins'); use_ok('Koha::Plugins::Handler'); @@ -28,6 +44,53 @@ BEGIN { my $schema = Koha::Database->new->schema; +subtest 'GetPlugins() tests' => sub { + + plan tests => 2; + + $schema->storage->txn_begin; + # Temporarily remove any installed plugins data + Koha::Plugins::Methods->delete; + + my $plugins = Koha::Plugins->new({ enable_plugins => 1 }); + $plugins->InstallPlugins; + + my @plugins = $plugins->GetPlugins({ method => 'report' }); + + my @names = map { $_->get_metadata()->{'name'} } @plugins; + is( scalar grep( /^Test Plugin$/, @names), 1, "Koha::Plugins::GetPlugins functions correctly" ); + + @plugins = $plugins->GetPlugins({ metadata => { my_example_tag => 'find_me' } }); + @names = map { $_->get_metadata()->{'name'} } @plugins; + is( scalar @names, 2, "Only two plugins found via a metadata tag" ); + + $schema->storage->txn_rollback; +}; + +subtest 'Version upgrade tests' => sub { + + plan tests => 1; + + $schema->storage->txn_begin; + + my $plugin = Koha::Plugin::Test->new( { enable_plugins => 1, cgi => CGI->new } ); + + # make sure there's no version on the DB + $schema->resultset('PluginData') + ->search( { plugin_class => $plugin->{class}, plugin_key => '__INSTALLED_VERSION__' } ) + ->delete; + + $plugin = Koha::Plugin::Test->new( { enable_plugins => 1, cgi => CGI->new } ); + my $version = $plugin->retrieve_data('__INSTALLED_VERSION__'); + + is( $version, $plugin->get_metadata->{version}, 'Version has been populated correctly' ); + + $schema->storage->txn_rollback; +}; + +$schema->storage->txn_begin; +Koha::Plugins::Methods->delete; + Koha::Plugins->new( { enable_plugins => 1 } )->InstallPlugins(); ok( Koha::Plugins::Methods->search( { plugin_class => 'Koha::Plugin::Test' } )->count, 'Test plugin methods added to database' ); @@ -82,18 +145,6 @@ close $fh; my $classname = ref($plugin); like( $plugin->test_template($fn), qr/^I am $fn/, 'Template works' ); -# testing GetPlugins -my @plugins = Koha::Plugins->new({ enable_plugins => 1 })->GetPlugins({ - method => 'report' -}); -my @names = map { $_->get_metadata()->{'name'} } @plugins; -is( scalar grep( /^Test Plugin$/, @names), 1, "Koha::Plugins::GetPlugins functions correctly" ); -@plugins = Koha::Plugins->new({ enable_plugins => 1 })->GetPlugins({ - metadata => { my_example_tag => 'find_me' }, -}); -@names = map { $_->get_metadata()->{'name'} } @plugins; -is( scalar grep( /^Test Plugin$/, @names), 1, "GetPlugins also found Test Plugin via a metadata tag" ); - for my $pass ( 1 .. 2 ) { my $plugins_dir; my $module_name = 'Koha::Plugin::Com::ByWaterSolutions::KitchenSink'; @@ -160,28 +211,6 @@ subtest 'output and output_html tests' => sub { like($stdout, qr{¡Hola output_html!}, 'Correct data'); }; -subtest 'Version upgrade tests' => sub { - - plan tests => 1; - - $schema->storage->txn_begin; - - my $plugin = Koha::Plugin::Test->new( { enable_plugins => 1, cgi => CGI->new } ); - - # make sure there's no version on the DB - $schema->resultset('PluginData') - ->search( { plugin_class => $plugin->{class}, plugin_key => '__INSTALLED_VERSION__' } ) - ->delete; - - $plugin = Koha::Plugin::Test->new( { enable_plugins => 1, cgi => CGI->new } ); - my $version = $plugin->retrieve_data('__INSTALLED_VERSION__'); - - is( $version, $plugin->get_metadata->{version}, 'Version has been populated correctly' ); - - $schema->storage->txn_rollback; -}; - - subtest 'Test _version_compare' => sub { plan tests => 6; -- 2.11.0