@@ -, +, @@ overdue_notices.pl --- misc/cronjobs/overdue_notices.pl | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) --- a/misc/cronjobs/overdue_notices.pl +++ a/misc/cronjobs/overdue_notices.pl @@ -575,21 +575,11 @@ END_SQL } $borrowernumber = $data->{'borrowernumber'}; - my $borr; - if ($data->{'surname'} && $data->{'firstname'}) { - $borr = - $data->{'firstname'} . ', ' - . $data->{'surname'} . ' (' - . $borrowernumber . ')'; - } elsif ($data->{'surname'}) { - $borr = - $data->{'surname'} . ' (' - . $borrowernumber . ')'; - } elsif ($data->{'firstname'}) { - $borr = - $data->{'firstname'} . ' (' - . $borrowernumber . ')'; - } + my $borr = sprintf( "%s%s%s (%s)", + $data->{'surname'} || '', + $data->{'firstname'} && $data->{'surname'} ? ', ' : '', + $data->{'firstname'} || '', + $borrowernumber ); $verbose and warn "borrower $borr has items triggering level $i."; --