Bugzilla – Attachment 89411 Details for
Bug 21280
Unify MARC editor in biblios and authorities
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21280: (follow-up) Adapt bug 21172 to Koha::MarcEditor
Bug-21280-follow-up-Adapt-bug-21172-to-KohaMarcEdi.patch (text/plain), 1.48 KB, created by
Josef Moravec
on 2019-05-07 06:28:55 UTC
(
hide
)
Description:
Bug 21280: (follow-up) Adapt bug 21172 to Koha::MarcEditor
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2019-05-07 06:28:55 UTC
Size:
1.48 KB
patch
obsolete
>From 4ad8d78a9ce277a96e515c67e96ec180b96785ed Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Mon, 6 May 2019 22:16:12 +0200 >Subject: [PATCH] Bug 21280: (follow-up) Adapt bug 21172 to Koha::MarcEditor > >Test plan: >As bug 21772 - read the code and confirm it makes sense > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > Koha/MarcEditor.pm | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > >diff --git a/Koha/MarcEditor.pm b/Koha/MarcEditor.pm >index a71fd3a..594d0c5 100644 >--- a/Koha/MarcEditor.pm >+++ b/Koha/MarcEditor.pm >@@ -89,18 +89,21 @@ sub build_tabs { > my %seen; > my @tab_data; # all tags to display > my $max_num_tab=-1; >+ my ( $itemtag, $itemsubfield ) = GetMarcFromKohaField( "items.itemnumber" ); > > if (defined $self->{used_tags}) { > foreach my $used ( @{$self->{used_tags}} ) { > push @tab_data,$used->{tagfield} if not $seen{$used->{tagfield}}; > $seen{$used->{tagfield}}++; >- } > >- foreach (@{$self->{used_tags}}) { >- if($_->{tab} > -1 && $_->{tab} >= $max_num_tab && $_->{tagfield} ne '995'){ # FIXME : MARC21 ? >- $max_num_tab = $_->{tab}; >+ if ( $used->{tab} > -1 >+ && $used->{tab} >= $max_num_tab >+ && $used->{tagfield} ne $itemtag ) >+ { >+ $max_num_tab = $used->{tab}; > } > } >+ > if ($max_num_tab >= 9) { > $max_num_tab = 9; > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21280
:
78214
|
85502
|
85503
|
85504
|
85517
|
85518
|
85519
|
85520
|
87311
|
87312
|
87313
|
87314
|
87318
|
87319
|
87320
|
87321
|
89407
|
89408
|
89409
|
89410
| 89411 |
89412
|
89413
|
89414