From 4861abe307bf30219a557c379502dba6910b98f7 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Tue, 7 May 2019 10:15:56 +0100 Subject: [PATCH] Bug 18506: (followup) Make this play nicely with opacPublic --- C4/Auth.pm | 17 +++++++++++++++++ .../bootstrap/en/includes/masthead.inc | 4 ++++ 2 files changed, 21 insertions(+) diff --git a/C4/Auth.pm b/C4/Auth.pm index 9388383694..d5cd2374c3 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -1057,6 +1057,23 @@ sub checkauth { } } + # If shib configured and shibOnly enabled, we should ignore anything other than a shibboleth type login. + if ( + $shib + && !$shibSuccess + && ( + ( + ( $type eq 'opac' ) + && C4::Context->preference('opacShibOnly') + ) + || ( ( $type ne 'opac' ) + && C4::Context->preference('staffShibOnly') ) + ) + ) + { + $return = 0; + } + # $return: 1 = valid user if ($return) { diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc index 91f908e868..1ef51c105f 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc @@ -71,6 +71,8 @@ [% IF Koha.Preference('casAuthentication') %] [%# CAS authentication is too complicated for modal window %]
  • Log in to create your own lists
  • + [% ELSIF shibbolethAuthentication && Koha.Preference('opacShibOnly') %] +
  • Log in to create your own lists
  • [% ELSE %]
  • Log in to create your own lists
  • [% END %] @@ -95,6 +97,8 @@
  • [% ELSIF ( Koha.Preference('GoogleOpenIDConnect') == 1 ) %]
  • + [% ELSIF shibbolethAuthentication && Koha.Preference('opacShibOnly') %] +
  • [% ELSE %]
  • [% END %] -- 2.20.1