Bugzilla – Attachment 89477 Details for
Bug 22790
The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22790: Add a test
Bug-22790-Add-a-test.patch (text/plain), 1.84 KB, created by
Jonathan Druart
on 2019-05-08 15:28:59 UTC
(
hide
)
Description:
Bug 22790: Add a test
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-05-08 15:28:59 UTC
Size:
1.84 KB
patch
obsolete
>From e0805c20b1991f7e6c78f5b8d5c481e4330e6054 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 8 May 2019 10:28:22 -0500 >Subject: [PATCH] Bug 22790: Add a test > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/SIP/Transaction.t | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t >index 646a5c153d..af3fa0aeb8 100755 >--- a/t/db_dependent/SIP/Transaction.t >+++ b/t/db_dependent/SIP/Transaction.t >@@ -31,7 +31,7 @@ is( $transaction->patron( $sip_patron ), $sip_patron, "Patron assigned to transa > isnt( $transaction->do_renew_all, undef, "RenewAll on zero items" ); > > subtest fill_holds_at_checkout => sub { >- plan tests => 5; >+ plan tests => 6; > > > my $category = $builder->build({ source => 'Category' }); >@@ -47,6 +47,7 @@ subtest fill_holds_at_checkout => sub { > my $biblio = $builder->build({ source => 'Biblio' }); > my $biblioitem = $builder->build({ source => 'Biblioitem', value=>{biblionumber=>$biblio->{biblionumber}} }); > my $item1 = $builder->build({ source => 'Item', value => { >+ barcode => 'barcode4test', > homebranch => $branch->{branchcode}, > holdingbranch => $branch->{branchcode}, > biblionumber => $biblio->{biblionumber}, >@@ -88,6 +89,9 @@ subtest fill_holds_at_checkout => sub { > $transaction->do_checkout(); > is( $bib->holds->count(), 1, "Bib has 1 holds remaining"); > >- >+ t::lib::Mocks::mock_preference('itemBarcodeInputFilter', 'whitespace'); >+ $sip_item = C4::SIP::ILS::Item->new( ' barcode 4 test '); >+ $transaction = C4::SIP::ILS::Transaction::Checkout->new(); >+ is( $sip_item->{barcode}, $item1->{barcode}, "Item assigned to transaction" ); > }; > $schema->storage->txn_rollback; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22790
:
88966
|
89394
|
89476
| 89477