Bugzilla – Attachment 89651 Details for
Bug 22891
ILS-DI: RenewLoan explodes in error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22891: (bug 21206 follow-up) Fix RenewHold (ILS-DI)
Bug-22891-bug-21206-follow-up-Fix-RenewHold-ILS-DI.patch (text/plain), 1.41 KB, created by
Marcel de Rooy
on 2019-05-13 09:29:43 UTC
(
hide
)
Description:
Bug 22891: (bug 21206 follow-up) Fix RenewHold (ILS-DI)
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-05-13 09:29:43 UTC
Size:
1.41 KB
patch
obsolete
>From b1a9753e48cbfd669952a31f94d170713544cc95 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sun, 12 May 2019 11:51:28 -0500 >Subject: [PATCH] Bug 22891: (bug 21206 follow-up) Fix RenewHold (ILS-DI) >Content-Type: text/plain; charset=utf-8 > >From > commit 31c29fd31f557306233e6a2936148a5bb10b89a1 > Bug 21206: Replace C4::Items::GetItem > >A missing 'unless' test made RenewHold return prematurely: > return $issue; >should have been > return unless $issue; > >Test plan: >Hit /cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=51&item_id=756 > >With different situations: >1. Item is checked out to the patron >2. Item is not checked out to the patron >3. Item does not exist >4. Patron does not exist > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/ILSDI/Services.pm | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm >index 8833094109..f6591ebe3b 100644 >--- a/C4/ILSDI/Services.pm >+++ b/C4/ILSDI/Services.pm >@@ -631,10 +631,8 @@ sub RenewLoan { > my @renewal = CanBookBeRenewed( $borrowernumber, $itemnumber ); > if ( $renewal[0] ) { AddRenewal( $borrowernumber, $itemnumber ); } > >- return unless $item; # FIXME should be handled >- > my $issue = $item->checkout; >- return $issue; # FIXME should be handled >+ return unless $issue; # FIXME should be handled > > # Hashref building > my $out; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22891
:
89640
|
89641
|
89650
| 89651