Bugzilla – Attachment 89669 Details for
Bug 22895
[18.11] cannot place item level holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22895: (bug 22650 follow-up) Correct itemnumber call in placerequest.pl
Bug-22895-bug-22650-follow-up-Correct-itemnumber-c.patch (text/plain), 1.53 KB, created by
Jonathan Druart
on 2019-05-13 15:50:11 UTC
(
hide
)
Description:
Bug 22895: (bug 22650 follow-up) Correct itemnumber call in placerequest.pl
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-05-13 15:50:11 UTC
Size:
1.53 KB
patch
obsolete
>From 258ba589fcf778489f42177c19dfc36c129c0eae Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 13 May 2019 15:07:41 +0000 >Subject: [PATCH] Bug 22895: (bug 22650 follow-up) Correct itemnumber call in > placerequest.pl > >Backport of 22650 makes an object call to an item hashref retrieved by get item: > > 94 if ( CanItemBeReserved($borrower->{'borrowernumber'}, $item->itemnumber, $branch)->{status} eq 'OK' ) { > >Should be $item->{itemnumber} > >To test: >1 - Try to place an item level hold >2 - It fails >3 - Aply patch >4 - Try again >5 - It works! > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > reserve/placerequest.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl >index 31b7e8c571..f89720fdd9 100755 >--- a/reserve/placerequest.pl >+++ b/reserve/placerequest.pl >@@ -91,7 +91,7 @@ if ( $type eq 'str8' && $borrower ) { > if ( $item->{'biblionumber'} ne $biblionumber ) { > $biblionumber = $item->{'biblionumber'}; > } >- if ( CanItemBeReserved($borrower->{'borrowernumber'}, $item->itemnumber, $branch)->{status} eq 'OK' ) { >+ if ( CanItemBeReserved($borrower->{'borrowernumber'}, $item->{'itemnumber'}, $branch)->{status} eq 'OK' ) { > AddReserve( $branch, $borrower->{'borrowernumber'}, > $biblionumber, \@realbi, $rank[0], $startdate, $expirationdate, $notes, $title, > $checkitem, $found, $itemtype ); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22895
:
89666
|
89669
|
89735