Bugzilla – Attachment 89883 Details for
Bug 22930
Make TestBuilder more strict about wrong arguments
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22930: (QA follow-up) Add two test descriptions
Bug-22930-QA-follow-up-Add-two-test-descriptions.patch (text/plain), 1.29 KB, created by
Marcel de Rooy
on 2019-05-17 08:42:28 UTC
(
hide
)
Description:
Bug 22930: (QA follow-up) Add two test descriptions
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-05-17 08:42:28 UTC
Size:
1.29 KB
patch
obsolete
>From 509fc6a95556b8aa05e415d6672cf91ecfb912f4 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 17 May 2019 08:35:20 +0000 >Subject: [PATCH] Bug 22930: (QA follow-up) Add two test descriptions >Content-Type: text/plain; charset=utf-8 > >No more than that ;) > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/TestBuilder.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/TestBuilder.t b/t/db_dependent/TestBuilder.t >index 09fcb225b1..6ad1810706 100644 >--- a/t/db_dependent/TestBuilder.t >+++ b/t/db_dependent/TestBuilder.t >@@ -401,7 +401,7 @@ subtest 'build_object() tests' => sub { > warnings_like { > $builder->build_object( > { class => 'Koha::Patrons', categorycode => 'foobar' } ); >- } qr{Unknown parameter\(s\): categorycode}, ""; >+ } qr{Unknown parameter\(s\): categorycode}, "Unknown parameter detected"; > }; > }; > >@@ -434,7 +434,7 @@ subtest '->build parameter' => sub { > warnings_like { > $builder->build( > { source => 'Borrower', categorycode => 'foobar' } ); >- } qr{Unknown parameter\(s\): categorycode}, ""; >+ } qr{Unknown parameter\(s\): categorycode}, "Unkown parameter detected"; > }; > > $schema->storage->txn_rollback; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22930
:
89864
|
89882
| 89883