From 7c175a1dac5951386124e6583f89d7478c265884 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 17 May 2019 09:53:56 +0000 Subject: [PATCH] Bug 22905: Counterpatch removing just branchcode Content-Type: text/plain; charset=utf-8 The suggested patches replace using $suggestion_only, making much more changes than needed. I would opt for removing the offending branchcode. In this case __ANY__. Apart from strict SQL mode, it is just wrong. This patch touches just one line. Same test plan. Signed-off-by: Marcel de Rooy --- suggestion/suggestion.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl index 845ed0ecca..9ff6a9319d 100755 --- a/suggestion/suggestion.pl +++ b/suggestion/suggestion.pl @@ -211,6 +211,7 @@ elsif ($op eq "change" ) { foreach my $suggestionid (@editsuggestions) { next unless $suggestionid; $suggestion_only->{'suggestionid'}=$suggestionid; + delete $suggestion_only->{branchcode}; # no need to change, could be __ANY__ causing data corruption &ModSuggestion($suggestion_only); } my $params = ''; -- 2.11.0