Bugzilla – Attachment 89920 Details for
Bug 22901
On item search authorised values select disappears on conditional change
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22901 - in items search fix search field change listerning
Bug-22901---in-items-search-fix-search-field-chang.patch (text/plain), 1.94 KB, created by
Maryse Simard
on 2019-05-17 20:01:51 UTC
(
hide
)
Description:
Bug 22901 - in items search fix search field change listerning
Filename:
MIME Type:
Creator:
Maryse Simard
Created:
2019-05-17 20:01:51 UTC
Size:
1.94 KB
patch
obsolete
>From c8ea449b0ad0680291636db98d8f863887b2f324 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 14 May 2019 08:22:43 +0200 >Subject: [PATCH] Bug 22901 - in items search fix search field change > listerning > >In items search, when there is a custom field with authorised values : >when changing the conditional select AND/OR then the authorised values select disappears. >This behaviour is like when the search field is changed. > >The bug is that JavaScript code meaning search field change listens on all selects instead of only search field select. > >Test plan : >1) Define a custom items search field with authorised values >2) Go to items search >3) Click on 'New field' >4) On second line, select custom field >5) The authorised values select appears >6) Select 'AND' in conditional select >7) Without patch the authorised values select disappears, with patch nothing changes >8) On second line, select a non-custom field >9) The authorised values select is replaced by a text field >10) On second line, select custom field >11) The authorised values select appears > >Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >index c01eab4..e1ac7ab 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >@@ -441,7 +441,7 @@ > form_field.append(button_field_new); > > // If a field is linked to an authorised values list, display the list. >- $('div.form-field-select-text select').change(function() { >+ $('div.form-field-select-text select[name="f"]').change(function() { > loadAuthorisedValuesSelect($(this)); > }).change(); > >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22901
:
89726
|
89920
|
90136