From 3001eeb32b6e1ff9db7bb05acb29a667cd62936e Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Wed, 22 May 2019 14:26:41 +0000 Subject: [PATCH] Bug 20436: (RM follow-up) Use Koha objects instead of mysql --- misc/cronjobs/longoverdue.pl | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/misc/cronjobs/longoverdue.pl b/misc/cronjobs/longoverdue.pl index 3bda469..17854e2 100755 --- a/misc/cronjobs/longoverdue.pl +++ b/misc/cronjobs/longoverdue.pl @@ -42,6 +42,8 @@ use Getopt::Long; use C4::Log; use Pod::Usage; use Koha::Patrons; +use Koha::Patron::Categories; +use Koha::ItemTypes; my $lost; # key=lost value, value=num days. my ($charge, $verbose, $confirm, $quiet); @@ -103,13 +105,14 @@ if ( scalar @$itemtype && scalar @$skip_itemtype) { } if ( $list_categories ) { - my @categories = sort map { uc $_->[0] } @{ C4::Context->dbh->selectall_arrayref(q|SELECT categorycode FROM categories|) }; + + my @categories = Koha::Patron::Categories->search()->get_column('categorycode'); print "\nBorrower Categories: " . join( " ", @categories ) . "\n\n"; exit 0; } if ( $list_itemtypes ) { - my @itemtypes = sort map { uc $_->[0] } @{ C4::Context->dbh->selectall_arrayref(q|SELECT itemtype FROM itemtypes|) }; + my @itemtypes = Koha::ItemTypes->search()->get_column('itemtype'); print "\nItemtypes: " . join( " ", @itemtypes ) . "\n\n"; exit 0; } @@ -293,7 +296,7 @@ sub longoverdue_sth { my $dbh = C4::Context->dbh; -my @available_categories = map { uc $_->[0] } @{ $dbh->selectall_arrayref(q|SELECT categorycode FROM categories|) }; +my @available_categories = Koha::Patron::Categories->search()->get_column('categorycode'); $borrower_category = [ map { uc $_ } @$borrower_category ]; $skip_borrower_category = [ map { uc $_} @$skip_borrower_category ]; my %category_to_process; @@ -321,7 +324,7 @@ if ( @$skip_borrower_category ) { my $filter_borrower_categories = ( scalar @$borrower_category || scalar @$skip_borrower_category ); -my @available_itemtypes = map { uc $_->[0] } @{ $dbh->selectall_arrayref(q|SELECT itemtype FROM itemtypes|) }; +my @available_itemtypes = Koha::ItemTypes->search()->get_column('itemtype'); $itemtype = [ map { uc $_ } @$itemtype ]; $skip_itemtype = [ map { uc $_} @$skip_itemtype ]; my %itemtype_to_process; -- 2.1.4