Bugzilla – Attachment 90127 Details for
Bug 22981
Remove type attribute from script tags: Catalog
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22981: Remove type attribute from script tags: Catalog
Bug-22981-Remove-type-attribute-from-script-tags-C.patch (text/plain), 2.95 KB, created by
Katrin Fischer
on 2019-05-27 20:57:26 UTC
(
hide
)
Description:
Bug 22981: Remove type attribute from script tags: Catalog
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-05-27 20:57:26 UTC
Size:
2.95 KB
patch
obsolete
>From e6bdf4fefc2ebc8923a8bc6cb72a050958ebb594 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 23 May 2019 18:35:31 +0000 >Subject: [PATCH] Bug 22981: Remove type attribute from script tags: Catalog > >This patch removes the "type" attribute from <script> tags in several >catalog-related templates. > >To test, apply the patch and confirm that the following work properly >without any JavaScript errors in the browser console: > > - Catalog -> Advanced search > - Catalog -> Item search > - Search history > >Validating the HTML source of these pages should return no errors >related to the "type" attribute. > >Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt | 3 +-- > 3 files changed, 3 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >index 7bfad35eae..b41c45f577 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >@@ -280,7 +280,7 @@ > > [% MACRO jsinclude BLOCK %] > [% Asset.js("lib/hc-sticky.js") | $raw %] >- <script type="text/JavaScript"> >+ <script> > /** > * Function add_field(); > * This function allows to display a new field to search. >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >index c01eab4e3b..1d9e563f04 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >@@ -220,7 +220,7 @@ > [% INCLUDE 'datatables.inc' %] > [% Asset.js("lib/jquery/plugins/jquery.dataTables.columnFilter.js") | $raw %] > [% Asset.js("lib/hc-sticky.js") | $raw %] >- <script type="text/javascript"> >+ <script> > var authorised_values = [% authorised_values_json | $raw %]; > > function loadAuthorisedValuesSelect(select) { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt >index 7852196c22..bc109f3fc0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt >@@ -193,8 +193,7 @@ > [% MACRO jsinclude BLOCK %] > [% INCLUDE 'datatables.inc' %] > [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %] >- <script type="text/javascript"> >- //<![CDATA[ >+ <script> > $(document).ready(function() { > // We show table ordered by descending dates by default > // (so that the more recent query is shown first) >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22981
:
90049
|
90058
| 90127