Bugzilla – Attachment 90205 Details for
Bug 23018
Refunding a lost item fee may trigger error if any fee has been written off related to that item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23018: Refunding a lost item fee may trigger error if any fee has been written off related to that item
Bug-23018-Refunding-a-lost-item-fee-may-trigger-er.patch (text/plain), 1.87 KB, created by
Kyle M Hall
on 2019-05-30 18:18:11 UTC
(
hide
)
Description:
Bug 23018: Refunding a lost item fee may trigger error if any fee has been written off related to that item
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2019-05-30 18:18:11 UTC
Size:
1.87 KB
patch
obsolete
>From 2172640de87487422f48b022ae4c0ad5a7a4e6ff Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 30 May 2019 14:15:52 -0400 >Subject: [PATCH] Bug 23018: Refunding a lost item fee may trigger error if any > fee has been written off related to that item > >If a lost item fee is written off, it creates a writeoff with the same itemnumber but the amount column is a negative number. > >Now, when the lost item is returned, it calls _FixAccountForLostAndReturned which searchs for all accountlines with an account type of 'L' or 'W'. > >Then, if the *first* of those lines has an outstanding balance, a credit is created and *all* the lines found are passed to $credit->apply. The apply method then calls is_debit on each line and when it hits the writeoff, it throws an exception ( Koha::Exceptions::Account::IsNotDebit ). > >When this happens, the credit is creating but not applied the the outstanding lost item fee, and the librarian is presented with an error page. > >It seems like the solution is to only fetch the first result since it seems like that is the only one we should be operating on. > >Test Plan: >1) Create a lost item with a fee >2) Create a manual debit using the barcode of the item >3) Write off that manual debit >4) Check in the item, note the error >5) Apply this patch >6) Repeat steps 1-3 >7) Check in the item, no error! >--- > C4/Circulation.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index e1b0ed6348..528b9f1459 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2411,7 +2411,8 @@ sub _FixAccountForLostAndReturned { > accounttype => { -in => [ 'L', 'W' ] }, > }, > { >- order_by => { -desc => [ 'date', 'accountlines_id' ] } >+ order_by => { -desc => [ 'date', 'accountlines_id' ] }, >+ rows => 1, > } > ); > >-- >2.20.1 (Apple Git-117)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23018
:
90205
|
90206
|
90640
|
91330