From 204efca0928e1c33dcc378e277c14ca5ef391153 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 21 May 2019 16:00:18 +0000
Subject: [PATCH] Bug 22952: Markup error in OPAC suggestions template

This patch makes a minor correction to the OPAC suggestions template in
order to quiet an error returned by the HTML validator.

To reproduce the problem you should have the 'suggestion' system
preference turned on, and you should be logged in to the OPAC as a user
who has submitted one or more suggestions. View the "your purchase
suggestions" page in the OPAC. Run the page through the W3C validation
service: https://validator.w3.org. Either by pasting in the URL for the
search results (if web accessible) or by viewing source, copying, and
pasting into "Validate by Direct Input."

This patch specifically addresses these errors:

 - "End tag div seen, but there were open elements."
 - "Unclosed element span."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Bin Wen <bin.wen@inlibro.com>
---
 .../opac-tmpl/bootstrap/en/modules/opac-suggestions.tt    | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
index 5ce43f2718..2da7660e84 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
@@ -267,9 +267,11 @@
 
                                     [% IF ( loggedinusername ) %]
                                         <div id="selections-toolbar" class="toolbar">
-                                              <span class="checkall"></span> <span class="clearall"></span> <span class="sep">|</span>
-                                              <span class="links"><span id="selections">Select suggestions to: </span>
-                                              <span id="removeitems"></span>
+                                            <span class="checkall"></span> <span class="clearall"></span> <span class="sep">|</span>
+                                            <span class="links">
+                                                <span id="selections">Select suggestions to: </span>
+                                                <span id="removeitems"></span>
+                                            </span>
                                         </div>
                                     [% END %]
 
-- 
2.17.1