Bugzilla – Attachment 90429 Details for
Bug 23048
Hide non-pickup branches from hold modification select
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23048: Hide non-pickup branches from hold modification select
Bug-23048-Hide-non-pickup-branches-from-hold-modif.patch (text/plain), 2.28 KB, created by
Bin Wen
on 2019-06-07 18:42:35 UTC
(
hide
)
Description:
Bug 23048: Hide non-pickup branches from hold modification select
Filename:
MIME Type:
Creator:
Bin Wen
Created:
2019-06-07 18:42:35 UTC
Size:
2.28 KB
patch
obsolete
>From cfccbdb64ed047f6e36ed11d5125a32c09c0a81a Mon Sep 17 00:00:00 2001 >From: Pasi Kallinen <pasi.kallinen@koha-suomi.fi> >Date: Wed, 5 Jun 2019 12:02:27 +0300 >Subject: [PATCH] Bug 23048: Hide non-pickup branches from hold modification > select > >When modifying holds in staff client via reserve/request.pl or >the holds-tab in members/moremember.pl, the pickup library dropdown >lists libraries not marked for pickup. Hide those branches. > >Signed-off-by: Pasi Kallinen <pasi.kallinen@koha-suomi.fi> >Signed-off-by: Bin Wen <bin.wen@inlibro.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/js/holds.js | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index a878658d21..c882af03ca 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -125,7 +125,7 @@ > [% Branches.GetName(hold.branchcode) | html %] <input type="hidden" name="pickup" value="[% hold.branchcode | html %]" /> > [% ELSE %] > <select name="pickup"> >- [% PROCESS options_for_libraries libraries => Branches.all( selected => hold.branchcode ) %] >+ [% PROCESS options_for_libraries libraries => Branches.all( selected => hold.branchcode, search_params => { pickup_location => 1 } ) %] > </select> > [% END %] > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js >index 1ca9a627c9..7b86de9694 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js >@@ -74,6 +74,7 @@ $(document).ready(function() { > for ( var i=0; i < oObj.branches.length; i++ ){ > var selectedbranch; > var setbranch; >+ if ( oObj.branches[i].pickup_location == 0 ) { continue; } > if( oObj.branches[i].selected ){ > > selectedbranch = " selected='selected' "; >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23048
:
90322
|
90429
|
91048
|
91453
|
91623