Bugzilla – Attachment 90490 Details for
Bug 21181
Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 21181: Make cancel_expired_reserves.pl Cancel all holds not waiting if ExpireReservesMaxPickupDelay not set
SIGNED-OFF-Bug-21181-Make-cancelexpiredreservespl-.patch (text/plain), 1.33 KB, created by
Claire Gravely
on 2019-06-11 13:40:10 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 21181: Make cancel_expired_reserves.pl Cancel all holds not waiting if ExpireReservesMaxPickupDelay not set
Filename:
MIME Type:
Creator:
Claire Gravely
Created:
2019-06-11 13:40:10 UTC
Size:
1.33 KB
patch
obsolete
>From 32f8e9806da50c438f66bbdbea27a9beafd5d02c Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 24 Apr 2019 01:22:06 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 21181: Make cancel_expired_reserves.pl > Cancel all holds not waiting if ExpireReservesMaxPickupDelay not set > >To test: >0 - Make sure ExpireReservesMaxPickupDelay is set to 'Don't allow' >1 - Place a hold for a patron >2 - Check in at another library to set it in transit >3 - Update expirationdate of hold to be in the past > UPDATE reserves SET expirationdate='1999-12-31' >4 - Run cancel_expired_holds.pl >5 - Hold is not canceled >6 - Apply patch >7 - Run again >8 - Hold is cancelled > >Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> >--- > C4/Reserves.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 205ed78..9c898a6 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -833,7 +833,7 @@ sub CancelExpiredReserves { > > my $dtf = Koha::Database->new->schema->storage->datetime_parser; > my $params = { expirationdate => { '<', $dtf->format_date($today) } }; >- $params->{found} = undef unless $expireWaiting; >+ $params->{found} = [ { '!=', 'W' }, undef ] unless $expireWaiting; > > # FIXME To move to Koha::Holds->search_expired (?) > my $holds = Koha::Holds->search( $params ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21181
:
77582
|
81049
|
88583
|
88584
|
90489
|
90490
|
91313
|
91314