Bugzilla – Attachment 90692 Details for
Bug 23104
Regression (18925) in circ rules - unlimited vs 0
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23104: (bug 18925 follow-up): Fix null/empty behavior, again
Bug-23104-bug-18925-follow-up-Fix-nullempty-behavi.patch (text/plain), 1.43 KB, created by
Katrin Fischer
on 2019-06-17 20:15:04 UTC
(
hide
)
Description:
Bug 23104: (bug 18925 follow-up): Fix null/empty behavior, again
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-06-17 20:15:04 UTC
Size:
1.43 KB
patch
obsolete
>From c29c02ac1facab0f5fdc3b522e3f47f7b123a6a8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 12 Jun 2019 09:12:27 -0500 >Subject: [PATCH] Bug 23104: (bug 18925 follow-up): Fix null/empty behavior, > again > >Not kidding, it's again, and will certainly appear more. >The problem is that we should have a NULL value in DB to make things >more readable and logical. Now we need a quick fix. > >Test plan: >Set "Current checkouts allowed" to unlimited (empty string) >Try to check an item out >=> Without this patch we are blocked with a "too many" message >=> With this patch applied the correct behavior is back! > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 9dd1a23774..3061a8e61a 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -412,7 +412,7 @@ sub TooMany { > # if a rule is found and has a loan limit set, count > # how many loans the patron already has that meet that > # rule >- if (defined($maxissueqty_rule) and defined($maxissueqty_rule->rule_value)) { >+ if (defined($maxissueqty_rule) and $maxissueqty_rule->rule_value ne '') { > my @bind_params; > my $count_query = q| > SELECT COUNT(*) AS total, COALESCE(SUM(onsite_checkout), 0) AS onsite_checkouts >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23104
:
90532
|
90533
|
90535
|
90536
|
90581
|
90666
|
90691
| 90692 |
90693
|
90694