Bugzilla – Attachment 90693 Details for
Bug 23104
Regression (18925) in circ rules - unlimited vs 0
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23104: Add tests for maxonsiteissueqty
Bug-23104-Add-tests-for-maxonsiteissueqty.patch (text/plain), 1.46 KB, created by
Katrin Fischer
on 2019-06-17 20:15:08 UTC
(
hide
)
Description:
Bug 23104: Add tests for maxonsiteissueqty
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-06-17 20:15:08 UTC
Size:
1.46 KB
patch
obsolete
>From e4e97f0f0041833b4405d849dc735646d7ca7854 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 13 Jun 2019 11:28:40 -0500 >Subject: [PATCH] Bug 23104: Add tests for maxonsiteissueqty > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > t/db_dependent/Circulation/TooMany.t | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Circulation/TooMany.t b/t/db_dependent/Circulation/TooMany.t >index 577a0dada9..a5ad9263a7 100644 >--- a/t/db_dependent/Circulation/TooMany.t >+++ b/t/db_dependent/Circulation/TooMany.t >@@ -661,7 +661,7 @@ subtest 'General vs specific rules limit quantity correctly' => sub { > }; > > subtest 'empty string means unlimited' => sub { >- plan tests => 1; >+ plan tests => 2; > > Koha::CirculationRules->set_rules( > { >@@ -670,7 +670,7 @@ subtest 'empty string means unlimited' => sub { > itemtype => '*', > rules => { > maxissueqty => '', >- maxonsiteissueqty => 0, >+ maxonsiteissueqty => '', > } > }, > ); >@@ -680,6 +680,12 @@ subtest 'empty string means unlimited' => sub { > 'maxissueqty="" should mean unlimited' > ); > >+ is( >+ C4::Circulation::TooMany( $patron, $biblio->{biblionumber}, $item, { onsite_checkout => 1 } ), >+ undef, >+ 'maxonsiteissueqty="" should mean unlimited' >+ ); >+ > teardown(); > }; > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23104
:
90532
|
90533
|
90535
|
90536
|
90581
|
90666
|
90691
|
90692
| 90693 |
90694