From 246ecc9420e326aa66cbb8ec2dfe7ca1d205a6cd Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Mon, 17 Jun 2019 21:12:25 +0000 Subject: [PATCH] Bug 22653: Remove unimplemented RotationPreventTransfers system preference This removes the RotationPreventTransfers system preference from updated and new installations. To test: - Verify you have the RotationPreventTransfers pref - Apply patch and run database update - Verify the preference no longer exists in your system - in the sys pref editor - in your database: SELECT * from systempreferences WHERE variable = "RotationPreventTransfers"; --- .../atomicupdate/bug_22653_remove_RotationPreventTransfers.perl | 6 ++++++ installer/data/mysql/sysprefs.sql | 1 - .../prog/en/modules/admin/preferences/circulation.pref | 6 ------ 3 files changed, 6 insertions(+), 7 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug_22653_remove_RotationPreventTransfers.perl diff --git a/installer/data/mysql/atomicupdate/bug_22653_remove_RotationPreventTransfers.perl b/installer/data/mysql/atomicupdate/bug_22653_remove_RotationPreventTransfers.perl new file mode 100644 index 0000000000..93facac48f --- /dev/null +++ b/installer/data/mysql/atomicupdate/bug_22653_remove_RotationPreventTransfers.perl @@ -0,0 +1,6 @@ +$DBversion = 'XXX'; +if( CheckVersion( $DBversion ) ) { + $dbh->do( "DELETE FROM systempreferences WHERE variable = 'RotationPreventTransfers'" ); + SetVersion( $DBversion ); + print "Upgrade to $DBversion done (Bug 22653 - Remove unimplemented RotationPreventTransfers system preference)\n"; +} diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql index 033c70e267..a0d1132d25 100644 --- a/installer/data/mysql/sysprefs.sql +++ b/installer/data/mysql/sysprefs.sql @@ -521,7 +521,6 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('reviewson','1','','If ON, enables patron reviews of bibliographic records in the OPAC','YesNo'), ('RisExportAdditionalFields', '', NULL , 'Define additional RIS tags to export from MARC records in YAML format as an associative array with either a marc tag/subfield combination as the value, or a list of tag/subfield combinations.', 'textarea'), ('RoutingListAddReserves','0','','If ON the patrons on routing lists are automatically added to holds on the issue.','YesNo'), -('RotationPreventTransfers','0',NULL,'If ON, prevent any transfers for items on stock rotation rotas, except for stock rotation transfers','YesNo'), ('RoutingListNote','To change this note edit RoutingListNote system preference.','70|10','Define a note to be shown on all routing lists','Textarea'), ('RoutingSerials','1',NULL,'If ON, serials routing is enabled','YesNo'), ('SCOMainUserBlock','','70|10','Add a block of HTML that will display on the self checkout screen','Textarea'), diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref index b526e5f5be..4799e86630 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ -1024,12 +1024,6 @@ Circulation: yes: Enable no: Disable - "the stock rotation module" - - - - pref: RotationPreventTransfers - choices: - yes: Disallow - no: Allow - - "library transfers on items in stockrotation rotas" Article Requests: - - pref: ArticleRequests -- 2.11.0