From 4b9d98dcecb142f168a28708a510c3594530e209 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi>
Date: Mon, 3 Jun 2019 14:58:34 +0000
Subject: [PATCH] Bug 23034: Remove uninitialized value warning in Mana KB
 settings

This gets rid of the warning "Use of uninitialized value $auto_share
in string ne at [...]" by initializing the variable with empty string.

Test plan:
1) Go to page cgi-bin/koha/admin/share_content.pl and unselect "Auto
   subscription sharing". Click "Save".
2) Check plack-error.log and notice the warning "Use of uninitialized
   value $auto_share [...]"
3) Apply the patch and repeat the previous steps but now this time the
   warning is gone in plack-error.log.
4) Make sure the AutoShareWithMana syspref with and without the patch
   is in unselected state after clicking "Save".

Sponsored-by: The National Library of Finland
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 admin/share_content.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/admin/share_content.pl b/admin/share_content.pl
index 2b9bd855e8..4f46316e55 100755
--- a/admin/share_content.pl
+++ b/admin/share_content.pl
@@ -41,7 +41,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
 my $op = $query->param('op') || q||;
 
 if ( $op eq 'save' ) {
-    my $auto_share = $query->param('autosharewithmana');
+    my $auto_share = $query->param('autosharewithmana') || q||;
     my $mana = $query->param('mana');
 
     C4::Context->set_preference('Mana', $mana);
-- 
2.20.1