Bugzilla – Attachment 90826 Details for
Bug 23166
Simplify code related to orders in catalogue/*detail.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23166: Remove baskets_orders code
Bug-23166-Remove-basketsorders-code.patch (text/plain), 5.16 KB, created by
Jonathan Druart
on 2019-06-20 02:37:42 UTC
(
hide
)
Description:
Bug 23166: Remove baskets_orders code
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-06-20 02:37:42 UTC
Size:
5.16 KB
patch
obsolete
>From 80fcee0bc4180a8f0217444e84efe62b4a905a23 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 19 Jun 2019 21:10:15 -0500 >Subject: [PATCH] Bug 23166: Remove baskets_orders code > >This is never used. >--- > catalogue/ISBDdetail.pl | 4 ---- > catalogue/MARCdetail.pl | 4 ---- > catalogue/detail.pl | 5 ----- > catalogue/imageviewer.pl | 4 ---- > catalogue/labeledMARCdetail.pl | 4 ---- > catalogue/moredetail.pl | 4 ---- > 6 files changed, 25 deletions(-) > >diff --git a/catalogue/ISBDdetail.pl b/catalogue/ISBDdetail.pl >index 79a173f1f9..d63b833ee4 100755 >--- a/catalogue/ISBDdetail.pl >+++ b/catalogue/ISBDdetail.pl >@@ -145,7 +145,6 @@ $template->param ( > my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber); > my @deletedorders_using_biblio; > my @orders_using_biblio; >-my @baskets_orders; > my @baskets_deletedorders; > > foreach my $myorder (@allorders_using_biblio) { >@@ -158,9 +157,6 @@ foreach my $myorder (@allorders_using_biblio) { > } > else { > push @orders_using_biblio, $myorder; >- unless (grep{ $_ eq $basket } @baskets_orders){ >- push @baskets_orders,$myorder->{'basketno'}; >- } > } > } > >diff --git a/catalogue/MARCdetail.pl b/catalogue/MARCdetail.pl >index b01c8ac4e6..4c175b5268 100755 >--- a/catalogue/MARCdetail.pl >+++ b/catalogue/MARCdetail.pl >@@ -321,7 +321,6 @@ $template->param ( > my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber); > my @deletedorders_using_biblio; > my @orders_using_biblio; >-my @baskets_orders; > my @baskets_deletedorders; > > foreach my $myorder (@allorders_using_biblio) { >@@ -334,9 +333,6 @@ foreach my $myorder (@allorders_using_biblio) { > } > else { > push @orders_using_biblio, $myorder; >- unless (grep { $_ eq $basket } @baskets_orders){ >- push @baskets_orders,$myorder->{'basketno'}; >- } > } > } > >diff --git a/catalogue/detail.pl b/catalogue/detail.pl >index b5f95a7350..cadedab62e 100755 >--- a/catalogue/detail.pl >+++ b/catalogue/detail.pl >@@ -515,7 +515,6 @@ if ($StaffDetailItemSelection) { > my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber); > my @deletedorders_using_biblio; > my @orders_using_biblio; >-my @baskets_orders; > my @baskets_deletedorders; > > foreach my $myorder (@allorders_using_biblio) { >@@ -528,9 +527,6 @@ foreach my $myorder (@allorders_using_biblio) { > } > else { > push @orders_using_biblio, $myorder; >- unless (grep{ $_ eq $basket } @baskets_orders){ >- push @baskets_orders,$myorder->{'basketno'}; >- } > } > } > >@@ -540,7 +536,6 @@ $template->param (countorders => $count_orders_using_biblio); > my $count_deletedorders_using_biblio = scalar @deletedorders_using_biblio ; > $template->param (countdeletedorders => $count_deletedorders_using_biblio); > >-$template->param (basketsorders => \@baskets_orders); > $template->param (basketsdeletedorders => \@baskets_deletedorders); > > output_html_with_http_headers $query, $cookie, $template->output; >diff --git a/catalogue/imageviewer.pl b/catalogue/imageviewer.pl >index 1716c0f3ea..b1d62dd929 100755 >--- a/catalogue/imageviewer.pl >+++ b/catalogue/imageviewer.pl >@@ -82,7 +82,6 @@ $template->{VARS}->{'biblio'} = $biblio; > my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber); > my @deletedorders_using_biblio; > my @orders_using_biblio; >-my @baskets_orders; > my @baskets_deletedorders; > > foreach my $myorder (@allorders_using_biblio) { >@@ -95,9 +94,6 @@ foreach my $myorder (@allorders_using_biblio) { > } > else { > push @orders_using_biblio, $myorder; >- unless (grep{ $_ eq $basket } @baskets_orders){ >- push @baskets_orders,$myorder->{'basketno'}; >- } > } > } > >diff --git a/catalogue/labeledMARCdetail.pl b/catalogue/labeledMARCdetail.pl >index 65c9ac280f..e6bb96c6ca 100755 >--- a/catalogue/labeledMARCdetail.pl >+++ b/catalogue/labeledMARCdetail.pl >@@ -128,7 +128,6 @@ $template->param ( > my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber); > my @deletedorders_using_biblio; > my @orders_using_biblio; >-my @baskets_orders; > my @baskets_deletedorders; > > foreach my $myorder (@allorders_using_biblio) { >@@ -141,9 +140,6 @@ foreach my $myorder (@allorders_using_biblio) { > } > else { > push @orders_using_biblio, $myorder; >- unless (grep{ $_ eq $basket } @baskets_orders){ >- push @baskets_orders,$myorder->{'basketno'}; >- } > } > } > >diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl >index b9520c0419..875b3a9a78 100755 >--- a/catalogue/moredetail.pl >+++ b/catalogue/moredetail.pl >@@ -228,7 +228,6 @@ $template->{'VARS'}->{'searchid'} = $query->param('searchid'); > my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber); > my @deletedorders_using_biblio; > my @orders_using_biblio; >-my @baskets_orders; > my @baskets_deletedorders; > > foreach my $myorder (@allorders_using_biblio) { >@@ -241,9 +240,6 @@ foreach my $myorder (@allorders_using_biblio) { > } > else { > push @orders_using_biblio, $myorder; >- unless (grep { $_ eq $basket } @baskets_orders){ >- push @baskets_orders,$myorder->{'basketno'}; >- } > } > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23166
:
90824
|
90825
|
90826
|
90827
|
90828
|
104365
|
104366
|
104367
|
104368
|
104369
|
104370
|
108991
|
108992
|
108993
|
108994
|
108995
|
108996
|
108997
|
108998
|
108999
|
109000
|
109001
|
109002
|
109019
|
109020
|
109021
|
109022
|
109023
|
109024
|
109025
|
109026
|
109037
|
109038
|
109039
|
109040
|
109041
|
109042
|
109043
|
109044
|
109045
|
109046
|
109047
|
109048
|
109049
|
109050
|
109058
|
109059