From 52bd3df4e641455b4e862e210508df5ddec748f1 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 21 Jun 2019 07:08:39 +0000 Subject: [PATCH] Bug 13640: (QA follow-up) Allow NULL values for default_branch_item_rules.holdallowed Content-Type: text/plain; charset=utf-8 If a rule has not been defined for an itemtype or you submit a biblio level hold, you cannot filter on holdallowed<>0. Test plan: Test with a biblio level hold. Have two items; one item should be blocked with a policy. Signed-off-by: Marcel de Rooy --- circ/pendingreserves.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl index 56acc2dcce..4fdfdacbd1 100755 --- a/circ/pendingreserves.pl +++ b/circ/pendingreserves.pl @@ -221,7 +221,7 @@ my $strsth = AND reserves.priority <> 0 AND reserves.suspend = 0 AND notforloan = 0 AND itemlost = 0 AND withdrawn = 0 - AND default_branch_item_rules.holdallowed != 0 + AND ( default_branch_item_rules.holdallowed IS NULL OR default_branch_item_rules.holdallowed != 0 ) "; # GROUP BY reserves.biblionumber allows only items that are not checked out, else multiples occur when # multiple patrons have a hold on an item -- 2.11.0