Bugzilla – Attachment 90872 Details for
Bug 13640
Holds To Pull List includes items unreserveable items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13640: (QA follow-up) Allow NULL values for default_branch_item_rules.holdallowed
Bug-13640-QA-follow-up-Allow-NULL-values-for-defau.patch (text/plain), 1.28 KB, created by
Marcel de Rooy
on 2019-06-21 07:13:44 UTC
(
hide
)
Description:
Bug 13640: (QA follow-up) Allow NULL values for default_branch_item_rules.holdallowed
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-06-21 07:13:44 UTC
Size:
1.28 KB
patch
obsolete
>From 52bd3df4e641455b4e862e210508df5ddec748f1 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 21 Jun 2019 07:08:39 +0000 >Subject: [PATCH] Bug 13640: (QA follow-up) Allow NULL values for > default_branch_item_rules.holdallowed >Content-Type: text/plain; charset=utf-8 > >If a rule has not been defined for an itemtype or you submit a biblio level >hold, you cannot filter on holdallowed<>0. > >Test plan: >Test with a biblio level hold. Have two items; one item should be blocked >with a policy. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > circ/pendingreserves.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index 56acc2dcce..4fdfdacbd1 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -221,7 +221,7 @@ my $strsth = > AND reserves.priority <> 0 > AND reserves.suspend = 0 > AND notforloan = 0 AND itemlost = 0 AND withdrawn = 0 >- AND default_branch_item_rules.holdallowed != 0 >+ AND ( default_branch_item_rules.holdallowed IS NULL OR default_branch_item_rules.holdallowed != 0 ) > "; > # GROUP BY reserves.biblionumber allows only items that are not checked out, else multiples occur when > # multiple patrons have a hold on an item >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13640
:
89665
|
90639
|
90871
| 90872