From da2dcb31d26c62dc338020c3b73a74ac66e77e2b Mon Sep 17 00:00:00 2001 From: David Bourgault Date: Fri, 29 Sep 2017 08:34:10 -0400 Subject: [PATCH] Bug 19368 - Correction on QA feedback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley Signed-off-by: Séverine QUEUNE --- .../data/mysql/atomicupdate/BugUndef-SerialSortIgnoreWords.sql | 2 +- installer/data/mysql/sysprefs.sql | 2 +- serials/serials-search.pl | 2 -- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/installer/data/mysql/atomicupdate/BugUndef-SerialSortIgnoreWords.sql b/installer/data/mysql/atomicupdate/BugUndef-SerialSortIgnoreWords.sql index 5bcdfda506..893b943226 100644 --- a/installer/data/mysql/atomicupdate/BugUndef-SerialSortIgnoreWords.sql +++ b/installer/data/mysql/atomicupdate/BugUndef-SerialSortIgnoreWords.sql @@ -1 +1 @@ -INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES ('SerialSortIgnoreWords','',NULL,'Words to ignore in serial search','Free'); \ No newline at end of file +INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES ('SerialSortIgnoreWords','',NULL,'Words to ignore in serial search','Free'); \ No newline at end of file diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql index 088b630b32..ddb2bc664f 100644 --- a/installer/data/mysql/sysprefs.sql +++ b/installer/data/mysql/sysprefs.sql @@ -542,7 +542,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('SendAllEmailsTo','',NULL,'All emails will be redirected to this email if it is not empty','free'), ('SeparateHoldings','0',NULL,'Separate current branch holdings from other holdings','YesNo'), ('SeparateHoldingsBranch','homebranch','homebranch|holdingbranch','Branch used to separate holdings','Choice'), -('SerialSortIgnoreWords','des du de la le les leur d l an a the',NULL,'Words to ignore in serial search','Free'), +('SerialSortIgnoreWords','',NULL,'Words to ignore in serial search','Free'), ('SessionRestrictionByIP','1','Check for change in remote IP address for session security. Disable only when remote IP address changes frequently.','','YesNo'), ('SessionStorage','mysql','mysql|Pg|tmp','Use database or a temporary file for storing session data','Choice'), ('ShelfBrowserUsesCcode','1','0','Use the item collection code when finding items for the shelf browser.','YesNo'), diff --git a/serials/serials-search.pl b/serials/serials-search.pl index e64bfed74d..495a98893c 100755 --- a/serials/serials-search.pl +++ b/serials/serials-search.pl @@ -176,8 +176,6 @@ for my $sub ( @subscriptions ) { $subsctitle =~ s/^\s+//; $sub->{titlesort} = ucfirst($subsctitle); - warn $subsctitle; - unless ( $sub->{closed} ) { push @openedsubscriptions, $sub unless $sub->{cannotdisplay}; -- 2.17.1