Bugzilla – Attachment 91015 Details for
Bug 23194
Public notes items in the OPAC should allow for HTML tags
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 23194: Fix other occurences
SIGNED-OFF-Bug-23194-Fix-other-occurences.patch (text/plain), 9.94 KB, created by
Claire Gravely
on 2019-06-26 10:54:20 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 23194: Fix other occurences
Filename:
MIME Type:
Creator:
Claire Gravely
Created:
2019-06-26 10:54:20 UTC
Size:
9.94 KB
patch
obsolete
>From c0bcfab427fcd45068e3460eb7766dd96684b925 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 25 Jun 2019 11:44:12 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 23194: Fix other occurences > >Throughout staff client and course reserves we also show the field with HTML filter, maybe we shouldn't? > >The items lost report also included the note as a title element on title and barcode links, I removed this >as the note displays in that table > >To test: > 1 - Add a link to publicnotes for an item ><a href="www.google.com">Cats!</a> > 2 - View opac details, confirm the note is a link > 3 - Same for staff side > 4 - Add item to a course reserve > UseCourseReserves preference must be set to 'Use' > From the course reserves module you will need to add a course (and possibly a department first) > Adding should be intuitive > 5 - Confirm note is a link in course details on staff and opac > 6 - Perform a batch checkout, confirm the itemnote shows as a link > You will need to enable the system preference: BatchCheckouts and add a patron category to: BatchCheckoutsValidCategories > Then a link should be available from checkout for a patron in that category > 7 - Mark the item as lost > 8 - Go to Reports->Items lost > 9 - Confirm the note is a URL and that title and barcode links don't show the note >10 - Click the barcode to go to moredetails for the item - in this case note should display as editable text, not a link > >Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +- > .../prog/en/modules/circ/circulation_batch_checkouts.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/on-site_checkouts.tt | 2 +- > .../intranet-tmpl/prog/en/modules/course_reserves/course-details.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt | 6 +++--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt | 2 +- > 6 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 6af2687..a963b84 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -360,7 +360,7 @@ > <td class="materials"> [% item.materials | html %] </td> > [% END %] > [% IF ( itemdata_itemnotes ) %] >- <td><div class="itemnotes">[% item.itemnotes | html %]</div></td> >+ <td><div class="itemnotes">[% item.itemnotes | $raw %]</div></td> > [% END %] > [% IF itemdata_nonpublicnotes %] > <td class="nonpublicnote">[% item.itemnotes_nonpublic | html %]</td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt >index 281eec1..7539633 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt >@@ -117,7 +117,7 @@ > [% END %] > <td>[% checkout_info.barcode | html %]</td> > <td> >- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% checkout_info.biblio.biblionumber | uri %]&type=intra"><strong>[% checkout_info.biblio.title | html %][% FOREACH subtitle IN checkout_info.biblio.subtitles %] [% subtitle.subfield | html %][% END %]</strong></a>[% IF checkout_info.biblio.author %], by [% checkout_info.biblio.author | html %][% END %][% IF ( checkout_info.item.itemnotes ) %]- <span class="circ-hlt">[% checkout_info.item.itemnotes | html %]</span>[% END %] <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% checkout_info.biblio.biblionumber | html %]&itemnumber=[% checkout_info.item.itemnumber | html %]#item[% checkout_info.item.itemnumber | html %]">[% checkout_info.item.barcode | html %]</a> >+ <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% checkout_info.biblio.biblionumber | uri %]&type=intra"><strong>[% checkout_info.biblio.title | html %][% FOREACH subtitle IN checkout_info.biblio.subtitles %] [% subtitle.subfield | html %][% END %]</strong></a>[% IF checkout_info.biblio.author %], by [% checkout_info.biblio.author | html %][% END %][% IF ( checkout_info.item.itemnotes ) %]- <span class="circ-hlt">[% checkout_info.item.itemnotes | $raw %]</span>[% END %] <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% checkout_info.biblio.biblionumber | html %]&itemnumber=[% checkout_info.item.itemnumber | html %]#item[% checkout_info.item.itemnumber | html %]">[% checkout_info.item.barcode | html %]</a> > </td> > <td> > [% IF checkout_info.NEEDSCONFIRMATION %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/on-site_checkouts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/on-site_checkouts.tt >index 6b1d94f..18ff03d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/on-site_checkouts.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/on-site_checkouts.tt >@@ -48,7 +48,7 @@ > <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% item.borrowernumber | uri %]">[% item.firstname | html %] [% item.surname | html %]</a> > </td> > <td> >- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% item.biblionumber | uri %]"><strong>[% item.title | html %]</strong></a>[% IF ( item.author ) %], by [% item.author | html %][% END %][% IF ( item.itemnotes ) %]- <span class="circ-hlt">[% item.itemnotes | html %]</span>[% END %] >+ <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% item.biblionumber | uri %]"><strong>[% item.title | html %]</strong></a>[% IF ( item.author ) %], by [% item.author | html %][% END %][% IF ( item.itemnotes ) %]- <span class="circ-hlt">[% item.itemnotes | $raw %]</span>[% END %] > </td> > <td>[% item.itemcallnumber | html %]</td> > <td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt >index 446192d..35a6f37 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt >@@ -190,7 +190,7 @@ > <td>[% IF (cr.public_note) %] > [% cr.public_note | html %] > [% ELSIF (cr.item.itemnotes) %] >- [% cr.item.itemnotes | html %] >+ [% cr.item.itemnotes | $raw %] > [% END %] > </td> > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >index 36d1f24..45e1e07 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >@@ -99,13 +99,13 @@ > </td> > [% END %] > <td> >- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% item.biblionumber | uri %]" title="[% item.itemnotes | html %]">[% item.biblio.title | html %]</a> >+ <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% item.biblionumber | uri %]">[% item.biblio.title | html %]</a> > </td> > <td>[% item.biblio.author | html %]</td> > <td>[% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.itemlost', authorised_value => item.itemlost ) | html %] > <td><span title="[% item.itemlost_on | html %]">[% item.itemlost_on | $KohaDates %]</span></td> > <td> >- <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% item.biblionumber | uri %]" title="[% item.itemnotes | html %]">[% item.barcode | html %]</a> >+ <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% item.biblionumber | uri %]">[% item.barcode | html %]</a> > </td> > <td>[% item.itemcallnumber | html %]</td> > <td><span title="[% item.datelastseen | html %]">[% item.datelastseen | $KohaDates %]</span></td> >@@ -117,7 +117,7 @@ > <td>[% Branches.GetName(item.holdingbranch) | html %]</td> > <td>[% AuthorisedValues.GetByCode( 'LOC', item.location ) | html %]</td> > <td>[% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.notforloan', authorised_value => item.notforloan ) | html %] >- <td>[% item.itemnotes | html %]</td> >+ <td>[% item.itemnotes | $raw %]</td> > </tr> > [% END %] > </tbody> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >index 17677bd..b47c376 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >@@ -80,7 +80,7 @@ > <td>[% IF ( cr.public_note ) %] > [% cr.public_note | html %] > [% ELSIF ( cr.item.itemnotes ) %] >- [% cr.item.itemnotes | html %] >+ [% cr.item.itemnotes | $raw %] > [% END %] > </td> > <td>[% IF (cr.item.uri) %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23194
:
90987
|
90988
|
91014
|
91015
|
91370
|
91371
|
91389
|
91390