From 5c88a053e0017fb5ef39118296265458ff6cb144 Mon Sep 17 00:00:00 2001 From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Date: Mon, 6 May 2019 12:10:58 -0500 Subject: [PATCH] Bug 18928: Remove '(not set)' The "(not set)" part must be removed IMO, I am not sure I understand its goal. Now that we have 1 entry per rule (and not 1 DB row for the whole "Default checkout, hold and return policy for Centerville" table), it will be harder to handle it correctly. Not impossible, but if not really needed I would prefer to just remove it. If a rule is not set, the cell is empty or the dropdown list displays the option "Not set", which seems to correct the problem. Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt index 33569610cf..f7e4e0ad9e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ -409,7 +409,7 @@ <th>Actions</th> </tr> <tr> - <td><em>Defaults[% UNLESS ( default_rules ) %] (not set)[% END %]</em></td> + <td><em>Defaults</em></td> <td> [% SET patron_maxissueqty = CirculationRules.Search( current_branch, undef, undef, 'patron_maxissueqty' ) %] <input type="text" name="patron_maxissueqty" size="3" value="[% patron_maxissueqty | html %]"/> -- 2.11.0