From 32ba8371da220a2f754b5224b1e8746cc6879079 Mon Sep 17 00:00:00 2001 From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Date: Sat, 29 Jun 2019 10:18:29 -0500 Subject: [PATCH] Bug 23218: Fix shift in patron's attributes in batch patron modification When the "new" button is clicked without selecting a patron's attribute, the update will have unexpected behaviors. There is indeed a difference in the number of patron's attributes and the number of values. Test plan: Go to the batch patron modification Enter a cardnumber At the bottom of the page, click "new" without selecting an attribute On the second line select one, and a value (different than an empty string) Save => The attribute will be updated with an empty string --- koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt index f976bda680..3c0b691d7c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt @@ -268,7 +268,7 @@ </select> </label> <input type="checkbox" title="check to delete this field" name="disable_input" value="attr0_value" /> - <span class="patron_attributes_value"></span> + <span class="patron_attributes_value"><input type"hidden" name="patron_attributes_value" value="poeut"/></span> <a href="#" class="add_attributes" title="Add an attribute"><i class="fa fa-fw fa-plus"></i> New</a> <span class="information_category hint" style="width:25%;float:right;"></span> </li> @@ -396,7 +396,7 @@ span.html('<input type="text" name="patron_attributes_value"/>'); $(disable_input_node).show(); } else { - span.html(''); + span.html('<input type="hidden" name="patron_attributes_value" />'); $(disable_input_node).hide(); } } -- 2.11.0