Bugzilla – Attachment 91137 Details for
Bug 23045
Advanced cataloging editor (rancor) throws a JS error on incomplete/blank lines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23045: Return record along with errors
Bug-23045-Return-record-along-with-errors.patch (text/plain), 1.30 KB, created by
Martin Renvoize
on 2019-07-01 09:15:46 UTC
(
hide
)
Description:
Bug 23045: Return record along with errors
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2019-07-01 09:15:46 UTC
Size:
1.30 KB
patch
obsolete
>From 6c3f0c7200a98d9c0b4aeaed9e53a4867fb160b8 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 7 Jun 2019 10:14:36 +0000 >Subject: [PATCH] Bug 23045: Return record along with errors > >We don't seem to directly handle the errors in most cases, let's always return the record > >To test: >1 - Add some blank lines to editor, previous patch is okay with this >2 - Add a line with just 'e' or some other incomplete field >3 - Try to save >4 - Note JS leader error >5 - Apply this patch >6 - No errors > >Signed-off-by: Liz Rea <wizzyrea@gmail.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/lib/koha/cateditor/text-marc.js | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/lib/koha/cateditor/text-marc.js b/koha-tmpl/intranet-tmpl/lib/koha/cateditor/text-marc.js >index 5846045bb7..b7623de805 100644 >--- a/koha-tmpl/intranet-tmpl/lib/koha/cateditor/text-marc.js >+++ b/koha-tmpl/intranet-tmpl/lib/koha/cateditor/text-marc.js >@@ -95,7 +95,8 @@ define( [ 'marc-record' ], function( MARC ) { > } > } ); > >- return errors.length ? { errors: errors } : record; >+ if( errors.length ) { record.errors = errors; } >+ return record; > } > }; > } ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23045
:
90320
|
90405
|
90411
|
90466
|
90467
|
91136
| 91137