Bugzilla – Attachment 91318 Details for
Bug 23199
Koha::Patron->store and uppercasesurname syspref
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23199: Koha::Patron->store must check 'uppercasesurname' syspref
Bug-23199-KohaPatron-store-must-check-uppercasesur.patch (text/plain), 1.80 KB, created by
Marcel de Rooy
on 2019-07-05 06:56:24 UTC
(
hide
)
Description:
Bug 23199: Koha::Patron->store must check 'uppercasesurname' syspref
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-07-05 06:56:24 UTC
Size:
1.80 KB
patch
obsolete
>From 532e046ef8a3cb305e29951443e32fe1cb1d6198 Mon Sep 17 00:00:00 2001 >From: Arthur Suzuki <arthur.suzuki@biblibre.com> >Date: Tue, 25 Jun 2019 11:17:24 +0200 >Subject: [PATCH] Bug 23199: Koha::Patron->store must check 'uppercasesurname' > syspref >Content-Type: text/plain; charset=utf-8 > >Test plan: >1/ set uppercasesurname to 'Do' >2/ register a new patron using the REST API with lowercase surname >3/ verify the surname is not saved in uppercase >4/ apply patch >5/ repeat 2 >6/ verify the surname now is saved to uppercase > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/Patron.pm | 4 ++++ > members/memberentry.pl | 4 ---- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index b1d9b14620..bde22cdd5a 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -193,6 +193,10 @@ sub store { > > $self->trim_whitespaces; > >+ # Set surname to uppercase if uppercasesurname is true >+ $self->surname( uc($self->surname) ) >+ if C4::Context->preference("uppercasesurname"); >+ > unless ( $self->in_storage ) { #AddMember > > # Generate a valid userid/login if needed >diff --git a/members/memberentry.pl b/members/memberentry.pl >index bd86e36b67..18f3a96466 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -343,10 +343,6 @@ if ($op eq 'save' || $op eq 'insert'){ > } > } > >- if($newdata{surname} && C4::Context->preference('uppercasesurnames')) { >- $newdata{'surname'} = uc($newdata{'surname'}); >- } >- > if (C4::Context->preference("IndependentBranches")) { > unless ( C4::Context->IsSuperLibrarian() ){ > $debug and print STDERR " $newdata{'branchcode'} : ".$userenv->{flags}.":".$userenv->{branch}; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23199
:
90982
|
90983
|
90996
|
91170
|
91171
|
91172
| 91318 |
91319
|
91320