Bugzilla – Attachment 91475 Details for
Bug 23219
Show a warning about cancelling their holds before a patron is deleted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23219: (QA follow-up) Change wording of test slightly
Bug-23219-QA-follow-up-Change-wording-of-test-slig.patch (text/plain), 1.28 KB, created by
Katrin Fischer
on 2019-07-12 06:17:41 UTC
(
hide
)
Description:
Bug 23219: (QA follow-up) Change wording of test slightly
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-07-12 06:17:41 UTC
Size:
1.28 KB
patch
obsolete
>From 91ffbc3e7f3ffb0dfe305bb5de4c0d6c3fe8f284 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Fri, 12 Jul 2019 06:15:38 +0000 >Subject: [PATCH] Bug 23219: (QA follow-up) Change wording of test slightly > >We no longer delete, but cancel the holds when deleting a patron. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > t/db_dependent/Koha/Patrons.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t >index b98037a9ce..5b789d5c18 100644 >--- a/t/db_dependent/Koha/Patrons.t >+++ b/t/db_dependent/Koha/Patrons.t >@@ -392,7 +392,7 @@ subtest "delete" => sub { > > is (Koha::Old::Holds->search( { reserve_id => $hold->{ reserve_id } } )->count, 1, q|Koha::Patron->delete should have cancelled patron's holds| ); > >- is( Koha::Holds->search( { borrowernumber => $patron->{borrowernumber} } )->count, 0, q|Koha::Patron->delete should have deleted patron's holds| ); >+ is( Koha::Holds->search( { borrowernumber => $patron->{borrowernumber} } )->count, 0, q|Koha::Patron->delete should have cancelled patron's holds 2| ); > > is( Koha::Virtualshelves->search( { owner => $patron->{borrowernumber} } )->count, 0, q|Koha::Patron->delete should have deleted patron's lists| ); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23219
:
91175
|
91281
|
91331
|
91333
|
91351
|
91395
|
91423
|
91473
|
91474
| 91475